351374 - compact folders confirmation should use yes/no

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

/mailnews/base/resources/locale/en-US/messenger.properties
autoCompactAllFoldersTitle=Compact Folders
autoCompactAllFolders=Do you wish to compact all local and offline folders to save disk space?
autoCompactAllFoldersCheckbox=Do this automatically from now on.

Questions should get yes/no rather than ok/cancel

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

Comment 2

[Karsten Düsterloh]

Comment on attachment 236768 [details] [diff] [review]
patch

>+ (nsIPrompt::BUTTON_TITLE_YES * nsIPrompt::BUTTON_POS_0 + nsIPrompt::BUTTON_TITLE_NO * nsIPrompt::BUTTON_POS_1),

It's a real nuisance that nsIPrompt doesn't define STD_YES_NO_BUTTONS like nsIPromptService does. Passing nsIPromptService::STD_YES_NO_BUTTONS should work, though, but that's more of a hack. :-/
r=me either way.

Comment 3

[[e-mail]]

Comment on attachment 236768 [details] [diff] [review]
patch

Please file a bug on getting the flags defined on nsIPrompt.idl

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Fixed on trunk.  Bug filed on nsIPrompt but I forgot its number :).

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #4)
> Fixed on trunk.  Bug filed on nsIPrompt but I forgot its number :).

Bug 351881