351412 - Implement children attribute on nsIAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Håkan Waara]

Comment 1

[Håkan Waara]

Attachment: Proposed patch

This simply implements the readonly attr |children|. Although it isn't fast now, it hopefully will be when bug 342045 is fixed.

Comment 2

[Aaron Leventhal]

Comment on attachment 236804 [details] [diff] [review]
Proposed patch

You can use NextChild() -- see nsIAccessibleHyperText.  It will be faster than cycling through the array |index| times each iteration of the loop.

Also, check into what's easier to use from Javasript -- nsIArray or nsIProperties. I thought Ming Gao found that nsIProperties was better for JS users of an interface, but I don't really know.

Comment 3

[Aaron Leventhal]

NextChild() example:
http://lxr.mozilla.org/seamonkey/source/accessible/src/html/nsHyperTextAccessible.cpp#125

Comment 4

[Håkan Waara]

Attachment: Patch v2

This patch uses the NextChild() method, and so the code was simplified. I don't think it makes sense to use nsIProperties in this case, since that's basically a hash table.

Comment 5

[Aaron Leventhal]

Comment on attachment 236955 [details] [diff] [review]
Patch v2

+  if (!children)
+    return NS_ERROR_FAILURE;
Can use NS_ENSURE_TRUE here since that shouldn't usually happen.

Please remove the extra whitespace change.

Comment 6

[Håkan Waara]

Checked in. Thanks for quick reviews.