Last Comment Bug 351443 - Remove unused code from mozilla/security/nss/lib/jar
: Remove unused code from mozilla/security/nss/lib/jar
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Tools (show other bugs)
: 3.11
: All All
: P3 normal (vote)
: 3.12
Assigned To: :Ehsan Akhgari
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-09-05 10:47 PDT by :Ehsan Akhgari
Modified: 2009-02-01 00:32 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch to remove unused code (6.22 KB, patch)
2006-09-05 10:49 PDT, :Ehsan Akhgari
nelson: review+
alvolkov.bgs: superreview+
Details | Diff | Splinter Review

Description :Ehsan Akhgari 2006-09-05 10:47:22 PDT
This bug is created to track removing unused code from mozilla/security/nss/lib/jar as discussed in bug #337361 comment #3.  The goal is removing code inside "#if 0" and "#if notdef" blocks.
Comment 1 :Ehsan Akhgari 2006-09-05 10:49:47 PDT
Created attachment 236819 [details] [diff] [review]
Patch to remove unused code

This patch simply removes the code blocks as mentioned in comment #0.  It should not have any affects on the code that actually gets executed, since the removed parts have been removed by the compiler anyway.
Comment 2 Nelson Bolyard (seldom reads bugmail) 2006-09-05 12:55:31 PDT
Comment on attachment 236819 [details] [diff] [review]
Patch to remove unused code

r=nelsonb
I have not attempted to verify that this patch eliminates ALL such code blocks, but my review affirms that it correctly removes the ones it intended to remove.
Thanks!
Comment 3 Nelson Bolyard (seldom reads bugmail) 2006-09-25 12:48:00 PDT
Unifdef USE_MOZ_THREAD (bug 351510) and remove dead code (bug 351443).
Patch contributed by ehsan.akhgari@gmail.com. r=nelson, alexei.volkov
Modified Files: jarint.h jarsign.c jarver.c manifest.mn
Removed Files: jarevil.c jarevil.h

Removing jarevil.c;      new revision: delete; previous revision: 1.8
Removing jarevil.h;      new revision: delete; previous revision: 1.3
Checking in jarint.h;    new revision: 1.5; previous revision: 1.4
Checking in jarsign.c;   new revision: 1.6; previous revision: 1.5
Checking in jarver.c;    new revision: 1.13; previous revision: 1.12
Checking in manifest.mn; new revision: 1.5; previous revision: 1.4

Note You need to log in before you can comment on or make changes to this bug.