351443 - Remove unused code from mozilla/security/nss/lib/jar

Status: RESOLVED FIXED

(NSS :: Tools, defect, P3)

Description

[(no longer active)]

This bug is created to track removing unused code from mozilla/security/nss/lib/jar as discussed in bug #337361 comment #3.  The goal is removing code inside "#if 0" and "#if notdef" blocks.

Comment 1

[(no longer active)]

Attachment: Patch to remove unused code

This patch simply removes the code blocks as mentioned in comment #0.  It should not have any affects on the code that actually gets executed, since the removed parts have been removed by the compiler anyway.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 236819 [details] [diff] [review]
Patch to remove unused code

r=nelsonb
I have not attempted to verify that this patch eliminates ALL such code blocks, but my review affirms that it correctly removes the ones it intended to remove.
Thanks!

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Unifdef USE_MOZ_THREAD (bug 351510) and remove dead code (bug 351443).
Patch contributed by [e-mail]. r=nelson, alexei.volkov
Modified Files: jarint.h jarsign.c jarver.c manifest.mn
Removed Files: jarevil.c jarevil.h

Removing jarevil.c;      new revision: delete; previous revision: 1.8
Removing jarevil.h;      new revision: delete; previous revision: 1.3
Checking in jarint.h;    new revision: 1.5; previous revision: 1.4
Checking in jarsign.c;   new revision: 1.6; previous revision: 1.5
Checking in jarver.c;    new revision: 1.13; previous revision: 1.12
Checking in manifest.mn; new revision: 1.5; previous revision: 1.4