The default bug view has changed. See this FAQ.

Remove unused code from mozilla/security/nss/lib/jar

RESOLVED FIXED in 3.12

Status

NSS
Tools
P3
normal
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

6.22 KB, patch
Nelson Bolyard (seldom reads bugmail)
: review+
Alexei Volkov
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
This bug is created to track removing unused code from mozilla/security/nss/lib/jar as discussed in bug #337361 comment #3.  The goal is removing code inside "#if 0" and "#if notdef" blocks.
(Assignee)

Comment 1

11 years ago
Created attachment 236819 [details] [diff] [review]
Patch to remove unused code

This patch simply removes the code blocks as mentioned in comment #0.  It should not have any affects on the code that actually gets executed, since the removed parts have been removed by the compiler anyway.
Attachment #236819 - Flags: superreview?(alexei.volkov.bugs)
Attachment #236819 - Flags: review?(nelson)
Comment on attachment 236819 [details] [diff] [review]
Patch to remove unused code

r=nelsonb
I have not attempted to verify that this patch eliminates ALL such code blocks, but my review affirms that it correctly removes the ones it intended to remove.
Thanks!
Attachment #236819 - Flags: review?(nelson) → review+
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED

Updated

11 years ago
Attachment #236819 - Flags: superreview?(alexei.volkov.bugs) → superreview+
Unifdef USE_MOZ_THREAD (bug 351510) and remove dead code (bug 351443).
Patch contributed by ehsan.akhgari@gmail.com. r=nelson, alexei.volkov
Modified Files: jarint.h jarsign.c jarver.c manifest.mn
Removed Files: jarevil.c jarevil.h

Removing jarevil.c;      new revision: delete; previous revision: 1.8
Removing jarevil.h;      new revision: delete; previous revision: 1.3
Checking in jarint.h;    new revision: 1.5; previous revision: 1.4
Checking in jarsign.c;   new revision: 1.6; previous revision: 1.5
Checking in jarver.c;    new revision: 1.13; previous revision: 1.12
Checking in manifest.mn; new revision: 1.5; previous revision: 1.4
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Priority: -- → P3
Resolution: --- → FIXED
Target Milestone: --- → 3.12
Version: trunk → 3.11
(Assignee)

Updated

10 years ago
Keywords: qawanted
(Assignee)

Updated

10 years ago
Keywords: qawanted
(Assignee)

Updated

10 years ago
Keywords: verifyme
(Assignee)

Updated

8 years ago
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.