Closed Bug 351460 Opened 13 years ago Closed 13 years ago

Print command disabled after click in task list until program end

Categories

(Calendar :: Sunbird Only, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dmose, Assigned: ssitter)

Details

(Whiteboard: [no l10n impact])

Attachments

(1 file)

Spun off from bug 325137.

When clicking into the task list the Print command toolbar button and the Print
menu entry are disabled. This is done in
http://lxr.mozilla.org/mozilla/source/calendar/resources/content/unifinderToDo.js#237
http://lxr.mozilla.org/mozilla/source/calendar/resources/content/unifinderToDo.js#245

But there is no code to enable the Print command if you select the views or the
event list or ... Thus the Print command stays disabled until program restart.
Flags: blocking0.3+
Whiteboard: [no l10n impact][needs patch]
Assignee: nobody → ssitter
Component: General → Sunbird Only
OS: Mac OS X 10.3 → All
QA Contact: general → sunbird
Attachment #237489 - Flags: second-review?(mvl)
Attachment #237489 - Flags: first-review?(mattwillis)
Comment on attachment 237489 [details] [diff] [review]
don't disable print command

This isn't my favourite way of fixing this, but it works for getting 0.3 shipped.

r1=lilmatt
Attachment #237489 - Flags: first-review?(mattwillis) → first-review+
Whiteboard: [no l10n impact][needs patch] → [patch in hand][needs review mvl][no l10n impact]
Comment on attachment 237489 [details] [diff] [review]
don't disable print command

>       document.getElementById( "delete_todo_command" ).removeAttribute( "disabled" );
>-      document.getElementById( "print_command" ).setAttribute( "disabled", "true" );

Doesn't this just want to be a removeAttribute("disabled") ?
(In reply to comment #3)
> Doesn't this just want to be a removeAttribute("disabled") ?

I don't think so. This would force users to click an empty row in task list to re-enable print commands for events. (This can be hard if you have a lot of tasks in that list.) In my opinion it's better to not disable the command at all.
Comment on attachment 237489 [details] [diff] [review]
don't disable print command

actually, the print command should not depend on current focus.
r2=mvl
Attachment #237489 - Flags: second-review?(mvl) → second-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [patch in hand][needs review mvl][no l10n impact] → [no l10n impact]
Verified in 0.3rc1
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061002 Sunbird/0.3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.