351460 - Print command disabled after click in task list until program end

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Dan Mosedale (:dmose, :dmosedale)]

Spun off from bug 325137.

When clicking into the task list the Print command toolbar button and the Print
menu entry are disabled. This is done in
http://lxr.mozilla.org/mozilla/source/calendar/resources/content/unifinderToDo.js#237
http://lxr.mozilla.org/mozilla/source/calendar/resources/content/unifinderToDo.js#245

But there is no code to enable the Print command if you select the views or the
event list or ... Thus the Print command stays disabled until program restart.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: don't disable print command

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 237489 [details] [diff] [review]
don't disable print command

This isn't my favourite way of fixing this, but it works for getting 0.3 shipped.

r1=lilmatt

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 237489 [details] [diff] [review]
don't disable print command

>       document.getElementById( "delete_todo_command" ).removeAttribute( "disabled" );
>-      document.getElementById( "print_command" ).setAttribute( "disabled", "true" );

Doesn't this just want to be a removeAttribute("disabled") ?

Comment 4

[Stefan Sitter [:ssitter]]

(In reply to comment #3)
> Doesn't this just want to be a removeAttribute("disabled") ?

I don't think so. This would force users to click an empty row in task list to re-enable print commands for events. (This can be hard if you have a lot of tasks in that list.) In my opinion it's better to not disable the command at all.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 237489 [details] [diff] [review]
don't disable print command

actually, the print command should not depend on current focus.
r2=mvl

Comment 6

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 7

[Todd Zimmerman]

Verified in 0.3rc1
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061002 Sunbird/0.3