351492 - HTTP authentication dialogs don't remember passwords, not prefilled

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.9a1) Gecko/20060905 Camino/1.2+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.9a1) Gecko/20060905 Camino/1.2+

HTTP authentication dialogs (those that pop up in a sheet) fail to remember the username/password, although it is store in the keychain.
The checkbox 'remember....' is also missing.

2006082604 (1.2+) -- OK
2006082701 (1.2+) -- Fails

Trunk only

Reproducible: Always

Steps to Reproduce:
1. go to site that asks for login (HTTP Auth)
2. 
3.

Actual Results:  
fields are blank, although the username and password are known



Expected Results:  
fields are prefiled

Filing under Camino atm. Might affect Firefox as well, but for some reason, Firefox never remembered my details on the few sites where I need this.

Comment 1

[philippe (part-time)]

Attachment: screen shot

Comment 2

[philippe (part-time)]

possibly  bug 265780

Comment 3

[Adam Guthrie]

See bug 227632 for the Firefox version of this. And yes, mwu says this'll be easy to fix once bug 265780 lands.

Comment 4

[philippe (part-time)]

Adam, you set this to 'branch', but on my copy of Camino 1.8.1 branch ('2006090504 '1.0+), this works correctly.
To be clear, and as far as *Camino* is concerned, this was working correctly (password remembered, fields prefilled) up to the 2006082604 (1.2+) trunk build.
It fails after that date.

Comment 5

[Adam Guthrie]

Ah, sorry about that. Maybe biesi can comment on that bug's possible affects on Camino.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

well it wasn't _supposed_ to cause any regressions, but it's of course possible that it caused some.

taking...

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

oh... camino implements nsIAuthPromptWrapper too... I missed that in my queries, this might explain it. I'll investigate this further tomorrow.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

OK, I hope I picked appropriate reviewers, please tell me if I didn't. Also, do I need an additional review?


And, sorry for taking so long to fix this :/

Comment 9

[Håkan Waara]

Comment on attachment 238563 [details] [diff] [review]
patch

Will we need to add a new .xpt-file to the build for this?

Comment 10

[Mark Mentovai]

Comment on attachment 238563 [details] [diff] [review]
patch

Looks good.  Has anyone tested this in Camino?

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

Yes, I did test this in Camino. No need for an xpt file.

Comment 12

[philippe (part-time)]

(In reply to comment #10)
> Looks good.  Has anyone tested this in Camino?

All working fine on my side.

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on trunk
Checking in src/application/AppComponents.mm;
/cvsroot/mozilla/camino/src/application/AppComponents.mm,v  <--  AppComponents.mm
new revision: 1.15; previous revision: 1.14
done
Checking in src/browser/CocoaPromptService.h;
/cvsroot/mozilla/camino/src/browser/CocoaPromptService.h,v  <--  CocoaPromptService.h
new revision: 1.7; previous revision: 1.6
done
Checking in src/browser/CocoaPromptService.mm;
/cvsroot/mozilla/camino/src/browser/CocoaPromptService.mm,v  <--  CocoaPromptService.mm
new revision: 1.22; previous revision: 1.21
done

Comment 14

[philippe (part-time)]

verified, fixed.