351545 - Junk mails are not correctly handled in Global Inbox (Local Folders)

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[frariv2009]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1b2) Gecko/20060821 SeaMonkey/1.1a
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1b2) Gecko/20060821 SeaMonkey/1.1a

Junk mails, when they are automatically or manually marked as junk, are not moved to the junk folder under Local Folder, although in both general preferences and account preferences is set to do so.

If the Junk folder is not already present, it is on created on junk tool first run.

Sample debugging procedure is provided.

Reproducible: Always

Steps to Reproduce:
1. mark manually any mail as spam in your Local Folders (It's the same with incoming mail, automatically marked as spam)
2. the mail is marked as junk (junk icons appear in mails list)


Actual Results:  
The mails manually or automatically marked as junk are not moved to the folder set in account preferences.

Expected Results:  
The mails marked as junk should be moved to the folder selected set in account preferences

Here is what I've done:

1) I did a clean SM 1.1a install. No old profile. I have deleted everything by hand before starting.
2) I've created a new Global Inbox account and I've set to move junk mails to Junk folder on this account (Local Folders).
3) I've created a fake junk mail sent from my web mail account. Mail subject: viagra viagra viagra, mail content: viagra viagra viagra (I've tried to keep it simple! ;-)
4) This mail was received and not marked as junk. It was the first one so it's ok.
5) I've marked it manually as spam. It was not moved to junk folder. No error in error console was displayed. Junk log entry was:
Detected junk message from gt tg <[e-mail]> - viagra viagra viagra at 2006-09-06 10:19:23 
6) I've created a *second* fake junk mail: same sender, same subject, same content.
7) The mail was correctly marked as Junk, but it was not moved. Indeed, the Junk folder is not even created under Local Folders and it doesn't help to create it by hand.
8) So I've created a second mail account that *doesn't* use Global Inbox and I've set it to move junk mails to Junk folder under this second account (not Local Folders).
9) I've sent a *third* junk mail: same sender, same subject, same content.
10) The mail is correctly marked as Junk *and* it is moved to the correct junk folder under this account. The junk folder is also created if it doesn't already exists.
11) If the junk folder in this second account is set to Local Folders Junk folder, the mail marked as junk are correctly moved (and the Local Folder junk folder created too if it doesn't exists), *but* the new mail sound sounds for Local Folders and this is not right if SM 1.1a correctly marks that mail as junk in Global Inbox.

I've searched in about:config and mail.server.default.moveOnSpam is set to "false" whatever option I choose via SM GUI, and it doesn't exist a mail.server.server1.moveOnSpam, where server1 is Local Folders (Global Inbox) on my system. 

Instead mail.server.server4.moveOnSpam (second account *without* Global Inbox) is correctly set to "true" and the destination is correctly set here.

So far, I can suppose that the whole junk tool is somehow broken when using Global Inbox since I've tried to set mail.server.default.moveOnSpam to "true" or to add mail.server.server1.moveOnSpam (set to "true") in addition to a destination folder set in about:config, without any appreciable change in how SM 1.1a (doesn't) handles junk mails.

Comment 1

[Andrew Schultz]

I'm seeing this with current trunk and 1.8 branch builds.

Comment 2

[Andrew Schultz]

OK, with a debug build, I get two of these
###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file /build/andrew/moz-debug/mozilla/rdf/base/src/nsRDFService.cpp, line 978
when I first load the junk settings pref pane.  This originates from
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/base/prefs/resources/content/am-junk.js&rev=1.3&mark=48-51#42
both *.value are intially ""

The problem is that they stay that way if the user doesn't take any action (and they don't feel the need to since the choices that get displayed look OK.  If I click "Local Folders" to activate the dropdown (it's the only choice) and select "Local Folders", then it all seems to work.

Comment 3

[frariv2009]

I've just tried this:

1) to delete an account I had create for this bug test;
2) to create a new Global Inbox account and set it to use Local Folders Junk folder by selecting it from the drop down list;
3) to send the usual fake junk mail;
4) the spam still is not moved to the junk folder.

Pay attention: since I have filed this bug report I've added 8 mail accounts that doesn't use Global Inbox in order to test SM more deeply, so when I've created the new one, the drop down list didn't show "Local Folders" as first entry, but the junk folder name of the first account I've previously created.

In addition, under about:config no option has changed.

Comment 4

[[e-mail]]

Here is how it used to be (correctly) done:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/base/resources/content/junkMail.js&rev=1.30&mark=121-136#118

Comment 5

[Andrew Schultz]

> 4) the spam still is not moved to the junk folder.

Hmm, was the junk folder created in Local Folders at least?

Comment 6

[frariv2009]

(In reply to comment #5)
> > 4) the spam still is not moved to the junk folder.
> 
> Hmm, was the junk folder created in Local Folders at least?

Well, it was already there from previous tests. 

Comment 7

[[e-mail]]

Attachment: Possible patch

Basically this copies Seth's code from the deceased junkMail.js

Comment 8

[Mike Cowperthwaite]

(In reply to comment #0)
> If the Junk folder is not already present, it is on created on junk tool first
> run.

Should that read "... it is *not* created on junk tool first run"?
I just opened bug 352225 about that problem, which is not limited to Global Inbox.

Comment 9

[frariv2009]

(In reply to comment #8)
> (In reply to comment #0)
> > If the Junk folder is not already present, it is on created on junk tool first
> > run.
> 
> Should that read "... it is *not* created on junk tool first run"?

Yes.

I've just tested Schultz's procedure in a new SM 1.1a installation with no previously created accounts and it works like he said: when I select "Local Folders" from the drop down list, the junk folder is created and junk is handled correctly.

Comment 10

[Karsten Düsterloh]

Comment on attachment 237743 [details] [diff] [review]
Possible patch

So, what is this patch supposed to fix? If I have junk moving enabled globally, create a new account, turn junk moving on on the account's pref panel, but do *not* touch the target junk folder drop down, no junk folder  is created and moving junk on marking as spam still doesn't work...
If I touch the dropdown, it works, though, but that's hardly an improvement...
(Tested with Mac trunk build.)

Comment 11

[Andrew Schultz]

Comment on attachment 237743 [details] [diff] [review]
Possible patch

>+  SetFolderPicker(spamActionTargetAccount, 'actionTargetAccount');

SetFolderPicker doesn't trigger calling onActionTargetChange, which is needed for the pref to actually be saved.
document.getElementById('server.spamActionTargetAccount').value = spamActionTargetAccount;
works

Comment 12

[[e-mail]]

Attachment: Updated patch

Comment 13

[Mike Cowperthwaite]

Does that patch also affect bug 268101?

Comment 14

[[e-mail]]

As far as I know all this does is fix a regression from bug 257990.

Comment 15

[Karsten Düsterloh]

Comment on attachment 240458 [details] [diff] [review]
Updated patch

>+  if (!spamActionTargetAccount) {

A last nit: you should move that { onto the next line in that file.

Comment 16

[[e-mail]]

Fix checked in, with the two {s put on their own line.

Comment 17

[[e-mail]]

Comment on attachment 240458 [details] [diff] [review]
Updated patch

Since this product has no thunderbird approval flags ;-)

Comment 18

[Andrew Schultz]

I filed bug 355197 and bug 355212 for remaining issues here...

Comment 19

[Mike Cowperthwaite]

*** Bug 352225 has been marked as a duplicate of this bug. ***

Comment 20

[Mike Cowperthwaite]

With TB3a1-1004, Win2K: verified that the 'spamActionXxx' prefs are set for the account and, when necessary, the folder is created,  when the 'Move messages' option is checked and the changes are accepted.

Comment 21

[Scott MacGregor]

Comment on attachment 240458 [details] [diff] [review]
Updated patch

a=mscott for thunderbird and seamonkey after talking to Neil.

This has no effect on Firefox but I don't have access to approve the 1.8.1 flag.

Comment 22

[Scott MacGregor]

Neil, I don't have access to approve the 1.8.1 flag, but this is a seamonkey/tb patch, so a=me even though we can't set the flag. Go ahead and land this on the branch.

Comment 23

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 240458 [details] [diff] [review]
Updated patch

a=beltzner on behalf of drivers (NPOTB)

Comment 24

[Wayne Mery (:wsmwk)]

does junk folder NOT have a junk icon as a symptom of this bug?

Comment 25

[Mike Cowperthwaite]

(In reply to comment #24)
> does junk folder NOT have a junk icon as a symptom of this bug?

If you're asking what I think you're asking, then yes.

Comment 26

[[e-mail]]

Fix checked in to the branch.

Comment 27

[Mike Cowperthwaite]

*** Bug 352163 has been marked as a duplicate of this bug. ***