351601 - Accessing the new navigator.buildID in a build w/o NS_BUILD_ID set shouldn't throw exception.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Johnny Stenback (:jst)]

Right now if you access navigator.buildID in anything other than an official build you'll get an exception. This is not a big problem for code in general, but it's already been reported that one web app (zimbra) triggers this and the way it does it is by enumerating the properties on the navigator object.

The fix for this is trivial, patch coming up.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Don't throw if NS_BUILD_ID is not set.

Comment 2

[Johnny Stenback (:jst)]

The buildID navigator property was introduced by bug 345993.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

See also bug 348069

Comment 4

[Reed Loden [:reed]]

*** Bug 348069 has been marked as a duplicate of this bug. ***

Comment 5

[Johnny Stenback (:jst)]

Fix landed on the trunk.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 237006 [details] [diff] [review]
Don't throw if NS_BUILD_ID is not set.

a=beltzner on behalf of 181drivers

Comment 7

[Johnny Stenback (:jst)]

Fix landed on the 1.8.1 branch.

Comment 8

[Robert Sayre]

RCS file: /cvsroot/mozilla/testing/mochitest/tests/test_bug351601.html,v
done
Checking in test_bug351601.html;
/cvsroot/mozilla/testing/mochitest/tests/test_bug351601.html,v  <--  test_bug351601.html
initial revision: 1.1
done