Closed Bug 351601 Opened 14 years ago Closed 14 years ago

Accessing the new navigator.buildID in a build w/o NS_BUILD_ID set shouldn't throw exception.

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jst, Assigned: jst)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

Right now if you access navigator.buildID in anything other than an official build you'll get an exception. This is not a big problem for code in general, but it's already been reported that one web app (zimbra) triggers this and the way it does it is by enumerating the properties on the navigator object.

The fix for this is trivial, patch coming up.
Assignee: general → jst
Status: NEW → ASSIGNED
Attachment #237006 - Flags: superreview?(bugmail)
Attachment #237006 - Flags: review?(bugmail)
Flags: blocking1.8.1?
The buildID navigator property was introduced by bug 345993.
Depends on: 345993
*** Bug 348069 has been marked as a duplicate of this bug. ***
Attachment #237006 - Flags: superreview?(bugmail)
Attachment #237006 - Flags: superreview+
Attachment #237006 - Flags: review?(bugmail)
Attachment #237006 - Flags: review+
Attachment #237006 - Flags: approval1.8.1?
Fix landed on the trunk.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Flags: blocking1.8.1? → blocking1.8.1+
Comment on attachment 237006 [details] [diff] [review]
Don't throw if NS_BUILD_ID is not set.

a=beltzner on behalf of 181drivers
Attachment #237006 - Flags: approval1.8.1? → approval1.8.1+
Fix landed on the 1.8.1 branch.
Keywords: fixed1.8.1
RCS file: /cvsroot/mozilla/testing/mochitest/tests/test_bug351601.html,v
done
Checking in test_bug351601.html;
/cvsroot/mozilla/testing/mochitest/tests/test_bug351601.html,v  <--  test_bug351601.html
initial revision: 1.1
done
Flags: in-testsuite+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.