Closed Bug 351645 Opened 18 years ago Closed 18 years ago

Sunbird - Chinese/Japanese/Korean installer's UI looks ugly

Categories

(Calendar :: Sunbird Only, defect)

Product:
Calendar
Component:
Sunbird Only
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Keywords: fixed1.8.1)

Attachments

(9 files)

Unofficial header - ja and ko
27.38 KB, image/png
mattwillis
: first-review+
Details
Unofficial watermark - ja and ko
163.18 KB, image/png
mattwillis
: first-review+
Details
Unofficial header - zh-CN and zh-TW
23.45 KB, image/png
mattwillis
: first-review+
Details
Unofficial watermark - zh-CN and zh-TW
139.39 KB, image/png
mattwillis
: first-review+
Details
Official header - ja and ko
27.38 KB, image/png
mattwillis
: first-review+
Details
Official watermark - ja and ko
163.18 KB, image/png
mattwillis
: first-review+
Details
Official header - zh-CN and zh-TW
23.45 KB, image/png
mattwillis
: first-review+
Details
Official watermark - zh-CN and zh-TW
139.39 KB, image/png
mattwillis
: first-review+
Details
branch patch
6.05 KB, patch
mattwillis
: first-review+
Details | Diff | Splinter Review
Spinoff of bug 344476 for Sunbird. Patch coming up within the next 24 hours.
Attachment #237176 - Flags: first-review?(mattwillis)
Attachment #237177 - Flags: first-review?(mattwillis)
Attachment #237178 - Flags: first-review?(mattwillis)
Attachment #237179 - Flags: first-review?(mattwillis)
Comment on attachment 237176 [details] Unofficial header - ja and ko r=lilmatt
Attachment #237176 - Flags: first-review?(mattwillis) → first-review+
Comment on attachment 237177 [details] Unofficial watermark - ja and ko r=lilmatt
Attachment #237177 - Flags: first-review?(mattwillis) → first-review+
Comment on attachment 237178 [details] Unofficial header - zh-CN and zh-TW r=lilmatt
Attachment #237178 - Flags: first-review?(mattwillis) → first-review+
Comment on attachment 237179 [details] Unofficial watermark - zh-CN and zh-TW r=lilmatt
Attachment #237179 - Flags: first-review?(mattwillis) → first-review+
Attachment #237180 - Flags: first-review?(mattwillis)
Attachment #237181 - Flags: first-review?(mattwillis)
Attachment #237182 - Flags: first-review?(mattwillis)
Attachment #237184 - Flags: first-review?(mattwillis)
That is all of the images... patch coming up shortly
Attached patch branch patch — — Splinter Review
This is only needed on the branch... for more info please see bug 344476
Attachment #237185 - Flags: first-review?(mattwillis)
Comment on attachment 237180 [details] Official header - ja and ko r=lilmatt
Attachment #237180 - Flags: first-review?(mattwillis) → first-review+
Comment on attachment 237184 [details] Official watermark - zh-CN and zh-TW r=lilmatt
Attachment #237184 - Flags: first-review?(mattwillis) → first-review+
Comment on attachment 237182 [details] Official header - zh-CN and zh-TW r=lilmatt
Attachment #237182 - Flags: first-review?(mattwillis) → first-review+
Comment on attachment 237181 [details] Official watermark - ja and ko r=lilmatt
Attachment #237181 - Flags: first-review?(mattwillis) → first-review+
Comment on attachment 237185 [details] [diff] [review] branch patch The branch patch in bug 344476 is needed for this patch to work
Comment on attachment 237185 [details] [diff] [review] branch patch r1=lilmatt
Attachment #237185 - Flags: first-review?(mattwillis) → first-review+
One of the current guideline for m/calendar is that branch and trunk should be in sync. So does this patch needs some #ifdef MOZILLA_1_8_BRANCH love? Or should this be checked in to trunk too even if not required?
Is it a guideline or a requirement and what is the goal / value for this? If required, yes the Sunbird installer will need some ifdef love and it would go on both the branch and trunk. If it isn't required, then this patch would only go on the branch.
Checked in to MOZILLA_1_8_BRANCH
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: