Closed
Bug 351650
Opened 18 years ago
Closed 17 years ago
Remove some bidi-specific code for setting start offsets of continuations
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: uriber, Assigned: uriber)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
4.35 KB,
patch
|
Details | Diff | Splinter Review |
The patch I'm about to attach removes some bidi-specific code, used for setting mContentOffset on continuation frames during reflow. This gets rid of two usages of the NS_FRAME_IS_BIDI flag, which is a step in the direction of removing this flag completely (except for TextBoxFrames), which, I think, is the best way to fix bug 333500. This change is possible following the fix for bug 299065. Here's how I understand the code I'm removing: In nsTextFrame::Reflow, the end offset of the prev-in-flow (if it exists) is used to set the start offset of this frame. However, for bidi continuations, there was (prior to 299065) no way to get to the previous bidi continuation (there was no PrevBidi property, just NextBidi). So the solution was not to touch the start offset in nsTextFrame::Reflow, but instead, set it correctly in advance, when dealing with the previous continuation in nsLineLayout::ReflowFrame. Since we can now easily access previous bidi continuations, this mechanism is no longer needed.
Assignee | ||
Comment 1•18 years ago
|
||
Assignee: nobody → uriber
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•17 years ago
|
||
I can't believe I never asked for review on this. Anyway, this ended up being done as part of fixing bug 385270.
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: layout.bidi → layout.fonts-and-text
You need to log in
before you can comment on or make changes to this bug.
Description
•