351661 - addBookmark.js -> bookmarkView.rdf.GetResource() should be RDF.GetResource()

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Philip Chee]

When addBookmark.xul is called with window.arguments[2] != null, I get a js error "bookmarkView.rdf has no properties. The fix is trivial and the firefox version of addBookmark.js has already been fixed (partially). Patch coming up.

Comment 1

[Philip Chee]

Attachment: Globally change bookmarkView.rdf.GetResource to RDF.GetResource

Comment 2

[Daniel Brooks [:db48x]]

Comment on attachment 237119 [details] [diff] [review]
Globally change bookmarkView.rdf.GetResource to RDF.GetResource

If Firefox has only partially fixed the bug, go ahead and attach a new patch that finishes fixing Firefox in addition to fixing xpfe. Otherwise r=db48x

Comment 3

[Philip Chee]

Attachment: Same fix for Firefox

Not tested since I don't use Firefox (much) but it matches:
http://lxr.mozilla.org/seamonkey/source/browser/components/bookmarks/content/addBookmark.js#124
Who on the Firefox side can I ask for a review?

Comment 4

[Daniel Brooks [:db48x]]

Comment on attachment 237321 [details] [diff] [review]
Same fix for Firefox

r=db48x

Comment 5

[Robert Kaiser]

Comment on attachment 237119 [details] [diff] [review]
Globally change bookmarkView.rdf.GetResource to RDF.GetResource

a=me for 1.1b

Comment 6

[Mark Banner (:standard8)]

Checked the SeaMonkey patch into Trunk:

Checking in xpfe/components/bookmarks/resources/addBookmark.js;
/cvsroot/mozilla/xpfe/components/bookmarks/resources/addBookmark.js,v  <--  addBookmark.js
new revision: 1.39; previous revision: 1.38

and branch:

Checking in xpfe/components/bookmarks/resources/addBookmark.js;
/cvsroot/mozilla/xpfe/components/bookmarks/resources/addBookmark.js,v  <--  addBookmark.js
new revision: 1.38.4.1; previous revision: 1.38

Let me know if you want the ff version checking in as well.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

FIXED, since bug 358602 was filed for Firefox.