351671 - edit recurrence: days/weeks/... is plural

Status: RESOLVED WORKSFORME

(Calendar :: General, defect)

Description

[Koen Hendrickx]

In the edit recurrence screen (for creating/editing a task or an event), the word days, weeks, months, years is plural.
This gives the problem: 'every 1 days' or weeks, months, years
Shouldn't this be the both symbol? 'every x day(s)' (week(s), ...)

I think the label 'repeat.units.days' must be replaced by 'repeat.units.days.both' (in /calendar/base/content/calendar-recurrence-dialog.xul, line 104)

Comment 1

[Frédéric Chateaux]

Attachment: Custom Reminder dialog

ProductID = "Sunbird05"
PlatformID = "LinuxIntel"
BuildID = "2007073104"

Step to reproduce :
  1- Open the New Event dialog
  2- In the "Reminder" dropdown list, select "Custom...", the "Custom Reminder" dialog appears.
  3- Set the "Reminder" field to values 1 and 10

Result :
  The dropdown list stay in plural mod. Days/Hours/Minutes should switch to singular when value is set to 1.

Files affected :
 - sun-calendar-event-reminder.xul
 - sun-calendar-event-reminder.js

In the upper reminders list, the switch between singular and plural mods works fine.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

I believe we fixed this during or shortly after the big alarm overhaul.