Closed
Bug 351693
Opened 19 years ago
Closed 19 years ago
Round-trip change with ternary with parenthesized constant condition
Categories
(Core :: JavaScript Engine, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla1.8.1
People
(Reporter: jruderman, Assigned: brendan)
Details
(Keywords: regression, testcase, verified1.8.1)
Attachments
(1 file)
946 bytes,
patch
|
mrbkap
:
review+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Before the recent change to parenthesization, "(0) ? x : y" would stay the same through decompilation. But now, the first decompilation removes the parens, and the second decompilation optimizes away the ternary due to the condition being 0.
js> function() { (0) ? x : y }
function () {
0 ? x : y;
}
js> function () {
0 ? x : y;
}
function () {
y;
}
Assignee | ||
Comment 1•19 years ago
|
||
Good for other fuzzer confounding tests that parenthesize constant conditions in if and ?:.
/be
Assignee | ||
Comment 2•19 years ago
|
||
Not worried about this, it's zero risk. Willing to spend time on review and approval, then commit it to the branch, to get it out of the fuzzer's face.
/be
OS: Mac OS X 10.4 → AIX
Priority: -- → P2
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.8.1
Updated•19 years ago
|
Attachment #237298 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 3•19 years ago
|
||
Fixed on trunk.
/be
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•19 years ago
|
||
Comment on attachment 237298 [details] [diff] [review]
trivial fix
This parentheses skipping is memoroy-safe, it's done elsewhere. It will help avoid defuzzing the fuzzer. I think we should take it for 1.8.1.
/be
Attachment #237298 -
Flags: approval1.8.1?
Comment 5•19 years ago
|
||
Comment on attachment 237298 [details] [diff] [review]
trivial fix
a=schrep for drivers.
Attachment #237298 -
Flags: approval1.8.1? → approval1.8.1+
Comment 7•19 years ago
|
||
Checking in regress-351693.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-351693.js,v <-- regress-351693.js
initial revision: 1.1
done
Flags: in-testsuite+
Comment 8•19 years ago
|
||
verified fixed 1.8 1.9 20060909 window/mac*/linux
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•