351693 - Round-trip change with ternary with parenthesized constant condition

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Jesse Ruderman]

Before the recent change to parenthesization, "(0) ? x : y" would stay the same through decompilation.  But now, the first decompilation removes the parens, and the second decompilation optimizes away the ternary due to the condition being 0.

js> function() { (0) ? x : y }
function () {
    0 ? x : y;
}

js> function () {
    0 ? x : y;
}
function () {
    y;
}

Comment 1

[Brendan Eich [:brendan]]

Attachment: trivial fix

Good for other fuzzer confounding tests that parenthesize constant conditions in if and ?:.

/be

Comment 2

[Brendan Eich [:brendan]]

Not worried about this, it's zero risk.  Willing to spend time on review and approval, then commit it to the branch, to get it out of the fuzzer's face.

/be

Comment 3

[Brendan Eich [:brendan]]

Fixed on trunk.

/be

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 237298 [details] [diff] [review]
trivial fix

This parentheses skipping is memoroy-safe, it's done elsewhere.  It will help avoid defuzzing the fuzzer. I think we should take it for 1.8.1.

/be

Comment 5

[Mike Schroepfer]

Comment on attachment 237298 [details] [diff] [review]
trivial fix

a=schrep for drivers.

Comment 6

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch.

/be

Comment 7

[Bob Clary [:bc] (inactive)]

Checking in regress-351693.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-351693.js,v  <--  regress-351693.js
initial revision: 1.1
done

Comment 8

[Bob Clary [:bc] (inactive)]

verified fixed 1.8 1.9 20060909 window/mac*/linux