Closed Bug 351693 Opened 19 years ago Closed 19 years ago

Round-trip change with ternary with parenthesized constant condition

Categories

(Core :: JavaScript Engine, defect, P2)

All
AIX
defect

Tracking

()

VERIFIED FIXED
mozilla1.8.1

People

(Reporter: jruderman, Assigned: brendan)

Details

(Keywords: regression, testcase, verified1.8.1)

Attachments

(1 file)

Before the recent change to parenthesization, "(0) ? x : y" would stay the same through decompilation. But now, the first decompilation removes the parens, and the second decompilation optimizes away the ternary due to the condition being 0. js> function() { (0) ? x : y } function () { 0 ? x : y; } js> function () { 0 ? x : y; } function () { y; }
Attached patch trivial fixSplinter Review
Good for other fuzzer confounding tests that parenthesize constant conditions in if and ?:. /be
Assignee: general → brendan
Status: NEW → ASSIGNED
Attachment #237298 - Flags: review?(mrbkap)
Not worried about this, it's zero risk. Willing to spend time on review and approval, then commit it to the branch, to get it out of the fuzzer's face. /be
OS: Mac OS X 10.4 → AIX
Priority: -- → P2
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.8.1
Attachment #237298 - Flags: review?(mrbkap) → review+
Fixed on trunk. /be
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 237298 [details] [diff] [review] trivial fix This parentheses skipping is memoroy-safe, it's done elsewhere. It will help avoid defuzzing the fuzzer. I think we should take it for 1.8.1. /be
Attachment #237298 - Flags: approval1.8.1?
Comment on attachment 237298 [details] [diff] [review] trivial fix a=schrep for drivers.
Attachment #237298 - Flags: approval1.8.1? → approval1.8.1+
Fixed on the 1.8 branch. /be
Keywords: fixed1.8.1
Checking in regress-351693.js; /cvsroot/mozilla/js/tests/js1_5/Regress/regress-351693.js,v <-- regress-351693.js initial revision: 1.1 done
Flags: in-testsuite+
verified fixed 1.8 1.9 20060909 window/mac*/linux
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: