Closed Bug 351812 Opened 13 years ago Closed 13 years ago

Broken links/redirects in Help

Categories

(SeaMonkey :: Help Documentation, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey1.1beta

People

(Reporter: stefanh, Assigned: prometeo.bugs)

Details

(Keywords: fixed-seamonkey1.1b)

Attachments

(3 files, 1 obsolete file)

I've checked the links the Help docs (branch/trunk). Found a few issues:
--------------------------------------------
cert_dialog_help.xhtml
http://kb.verisign.com/esupport/esupport/consumer/esupport.asp?id=vs2119
    Response status code: 404


http://www.verisign.com/support/install/index.html
I had to check this manually and it looks like it redirects to http://www.verisign.com/support/ssl-certificates-support/install-ssl-certificate.html
--------------------------------------------

glossary.xhtml

http://www.w3.org/xml/ redirected to
http://www.w3.org/XML/
    Response status code: 301 -> 200
    Response message: Moved Permanently -> OK

Then there are 5 internal links that doesn't work. Those are links to (line number where the error is):

personal_toolbar (line: 37)
password_manager (line: 380)
certificate_manager (line: 462)
proxy (line: 600)
tcp_ip (line: 623)
--------------------------------------------

nav_help.xhtml
http://lcweb.loc.gov/standards/iso639-2/langcodes.html redirected to
http://www.loc.gov/standards/iso639-2/langcodes.html
    Response status code: 301 -> 200
    Response message: Moved Permanently -> OK
--------------------------------------------

privacy_help.xhtml (This one seems to be trunk-only)

Line 57: "cs_nav_prefs_popup.xhtml#controlling_popups" should be "cs_priv_prefs_popup.xhtml#controlling_popups" ;-)
--------------------------------------------

profiles_help.xhtml
http://web.archive.org/web/20020605164606/http://help.netscape.com/products/client/communicator/manual_roaming2.html
This one is problematic. When checking this manually (robots.txt stops it from being checked automatically), the page seems dead:

"Failed Connection.

We're sorry. Your request failed to connect to our servers. We may be experiencing technical difficulties and suggest that you try again later.
See the FAQs for more info and help, or contact us."
--------------------------------------------

Giacomo, I'm assigning this one to you. If you don't want it, just yell ;-)
Small note: since the roaming document is usually referenced by other sites, I will try to contact deb about putting it on devmo (after wikification).
Once done, we can remove this last reference to webarchive. Not sure if this will make it before sm 1.1 (any version :) ).
Another note: the patch is against trunk. Can someone please verify that it applies to branch as well?
TIA, Giacomo.
(In reply to comment #2)
> Another note: the patch is against trunk. Can someone please verify that it
> applies to branch as well?
> TIA, Giacomo.
> 

patching file extensions/help/resources/locale/en-US/cert_dialog_help.xhtml
patching file extensions/help/resources/locale/en-US/glossary.xhtml
patching file extensions/help/resources/locale/en-US/nav_help.xhtml
Hunk #1 succeeded at 1233 (offset 20 lines).
patching file extensions/help/resources/locale/en-US/privacy_help.xhtml
Hunk #1 FAILED at 54.
1 out of 1 hunk FAILED -- saving rejects to file extensions/help/resources/locale/en-US/privacy_help.xhtml.rej
patching file extensions/help/resources/locale/en-US/profiles_help.xhtml

-----

I don't think the link is wrong in the 1.8 version of privacy_help.xhtml (see my initial comment). So, a 1.8 version of the patch would simply be the same patch but without the privacy_help diff.
Small nit:

+    <a href="http://knowledge.verisign.com/search/solution.jsp?id=vs2119">
+    	What is the purpose of the Intermediate CA certificate?</a></li>

iirc (and you don't seem to do like this all the time) you don't need the whitespaces here (there are more further down in the  patch). Once the patch is reviewed we also need to patch the help files in suite/locales/en-US/chrome/common/help.
Branch patch coming after review...
Attachment #237454 - Attachment is obsolete: true
Attachment #238177 - Flags: review?(iann_bugzilla)
Attachment #238177 - Flags: review?(iann_bugzilla)
Attachment #238177 - Flags: review+
Attachment #238177 - Flags: approval-seamonkey1.1b+
Whiteboard: [checkin needed]
Sidenote - we can recover a broken link in developer_tools too, like:
http://web.archive.org/web/20041123092656/http://www.brownhen.com/DI.html
This is another good candidate for DevMo...
Comment on attachment 238177 [details] [diff] [review]
Minor changes to previous patch, added changes for suiterunner

I landed this on trunk
Comment on attachment 238971 [details] [diff] [review]
Reduced version for branch (no privacy_help patch, so it shouldn't fail)

and landed this on the branch
please resolve if nothing more is needed here
Whiteboard: [checkin needed]
I got in touch with Ian and he gave me a pointer to a live copy of the "Introduction to DOMI" on his site. Do we want to uncomment & update one link in dev_tools?
(In reply to comment #11)
> I got in touch with Ian and he gave me a pointer to a live copy of the
> "Introduction to DOMI" on his site. Do we want to uncomment & update one link
> in dev_tools?
> 
Sounds like a good idea to me.
Attachment #240423 - Flags: review?(iann_bugzilla)
Attachment #240423 - Flags: review+
Attachment #240423 - Flags: approval-seamonkey1.1b+
Whiteboard: [checkin needed]
(In reply to comment #13)
> Created an attachment (id=240423) [edit]

Ian, can you please check this in on trunk and branch?
TIA, Giacomo.
Comment on attachment 240423 [details] [diff] [review]
Restore link to the Introduction to the DOMI by Ian (Checked into trunk / 1.8 branch)

Checking in (trunk)
extensions/help/resources/locale/en-US/developer_tools.xhtml;
new revision: 1.11; previous revision: 1.10
suite/locales/en-US/chrome/common/help/developer_tools.xhtml;
new revision: 1.12; previous revision: 1.11
done
Checking in (1.8 branch)
extensions/help/resources/locale/en-US/developer_tools.xhtml;
new revision: 1.7.8.4; previous revision: 1.7.8.3
done
Attachment #240423 - Attachment description: Restore link to the Introduction to the DOMI by Ian → Restore link to the Introduction to the DOMI by Ian (Checked into trunk / 1.8 branch)
Whiteboard: [checkin needed]
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.