351857 - Implement stub verasion of window.external.IsSearchProviderInstalled

Status: RESOLVED FIXED

(Firefox :: Search, defect, P2)

Description

[Mike Connor [:mconnor]]

Bug 340604 comment 11 points out a problem with partially implementing IE's API.  We should stub this out and just return false, instead of throwing.

Comment 1

[Pam Greene]

Attachment: Implements stub

Although I'm not sure whether adding a stub is the right thing to do (see bug 340604 comment #16), here's a patch in case we decide to go with it.

Comment 2

[Asaf Romano (gone)]

Comment on attachment 237391 [details] [diff] [review]
Implements stub

Semantically, you don't need to note the method isn't implemented inside the iface itself. It would be nice to put a link to the MS documentation for this methods though.

Any reason this isn't a "boolean" method (or, at the very least - "unsigned long")?

Note you need a dom/ peer review on this too.

Comment 3

[Pam Greene]

(In reply to comment #2)
> (From update of attachment 237391 [details] [diff] [review] [edit])
> Semantically, you don't need to note the method isn't implemented inside the
> iface itself. It would be nice to put a link to the MS documentation for this
> methods though.

Okay.  Put that link in the IDL, or in the JS?
 
> Any reason this isn't a "boolean" method (or, at the very least - "unsigned
> long")?

It isn't boolean because Microsoft's isn't boolean, and we might decide to support their full range of return values.  I used PRUint32 because I've used that in IDL files before, and JS doesn't much care.  (Neither do I, if someone prefers something else.)

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 237391 [details] [diff] [review]
Implements stub

IsSearchProviderInstalled returns 0 1 or 2 per the MS docs, so it can't be a boolean.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 237391 [details] [diff] [review]
Implements stub

>Index: dom/public/idl/sidebar/nsISidebar.idl
> interface nsISidebarExternal : nsISupports

Please add a link to the Microsoft documentation of this interface's methods.

>+    PRUint32 IsSearchProviderInstalled(in string aSearchURL);

unsigned long, please.

sr=bzbarsky with those nits picked.

Comment 6

[Pam Greene]

Attachment: De-nitted, as checked in on trunk

Landing on trunk to bake.

Comment 7

[Mike Schroepfer]

Comment on attachment 237801 [details] [diff] [review]
De-nitted, as checked in on trunk

a=schrep for drivers.

Comment 8

[Pam Greene]

Landing on 1.8.1 branch.

Comment 9

[Pam Greene]

Attachment: De-nitted, as checked in on branch