Closed
Bug 351864
Opened 19 years ago
Closed 19 years ago
Mark as Read by Date dumps error message for already read messages
Categories
(MailNews Core :: Backend, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bugzilla, Assigned: bugzilla)
References
()
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
1.48 KB,
patch
|
mnyromyr
:
review+
Bienvenu
:
superreview+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060821 SeaMonkey/1.1a
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060821 SeaMonkey/1.1a
http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/markByDate.js#139
The else case gets executed for all messages already marked as read. The result are hundred of those messages in the shell (one for every read message).
Reproducible: Always
|
Assignee | |
Comment 1•19 years ago
|
||
The patch moves the query for !header.isRead inside the outer if with the check for the correct header format. The error only gets dumped if header is broken and not for already read messages.
Attachment #237372 -
Flags: review?(mnyromyr)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #237372 -
Flags: superreview?(bienvenu)
|
||
Updated•19 years ago
|
Assignee: nobody → aqualon
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
||
Updated•19 years ago
|
Attachment #237372 -
Flags: review?(mnyromyr) → review+
|
||
Updated•19 years ago
|
Attachment #237372 -
Flags: superreview?(bienvenu) → superreview+
|
|
||
Comment 2•19 years ago
|
||
Checked in into trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•19 years ago
|
Attachment #237372 -
Flags: approval1.8.1?
|
|
Assignee | |
Comment 3•19 years ago
|
||
Asking for approval1.8.1, cause markByDate.js is a shared file between SeaMonkey and Thunderbird. The patch is low risk, only one if-clause was split to avoid the misleading error dumps.
|
||
Comment 4•19 years ago
|
||
Comment on attachment 237372 [details] [diff] [review]
Patch v1
a=beltzner on behalf of 181drivers
Attachment #237372 -
Flags: approval1.8.1? → approval1.8.1+
|
|
||
Comment 5•19 years ago
|
||
Checked in into MOZILLA_1_8_BRANCH.
|
|
||
Comment 6•19 years ago
|
||
adding the fixed1.8.1 keyword since Karsten landed this on the branch.
Keywords: fixed1.8.1
|
||
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•