351921 - Remove xpcom/obsolete/nsSpecialSystemDirectory.{h,cpp}

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mark Banner (:standard8)]

There's not too many uses of this in the mozilla tree - mainly mailnews and its also referenced in a couple of other places. Bug 351920 will remove the uses from mailnews, this bug will remove other uses and the files themselves.

Comment 1

[Mark Banner (:standard8)]

Attachment: Remove remaining uses and the files

This patch removes the remaining uses of nsSpecialSystemDirectory (replacing with appropriate code) and the files themselves. This will need the final patch on bug 351920 committing first, but that will hopefully be done soon.

Darin, if you're not the right person to review this, could you redirect me to someone who's better placed?

Comment 2

[jhp (no longer active)]

The code in the mozilla/java/plugins dir seems to be used by Ed Burns ([e-mail]), so you can get his review if necessary.  But no need to touch anything in mozilla/java/xpcom; that code is no longer built, won't build, and is just there for historical purposes.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 238791 [details] [diff] [review]
Remove remaining uses and the files

(In reply to comment #2)
> The code in the mozilla/java/plugins dir seems to be used by Ed Burns
> ([e-mail]), so you can get his review if necessary.  But no need to
> touch anything in mozilla/java/xpcom; that code is no longer built, won't
> build, and is just there for historical purposes.
> 

ok, thanks.

Ed, can you review just the java/plugins/src/PlugletsDir.cpp section of this patch? I'm removing some obsolete code, and the PlugletsDir.cpp is the last thing that is blocking me.

Comment 4

[edburns]

Looks good.  r=edburns for the PlugletsDir.cpp code.

I actually have that file modified in my workspace now.  Do you want me to just take your patch and incorporate it into my modified file or do you want to check it in and I'll do the merge?

Thanks very much,

Ed

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 238791 [details] [diff] [review]
Remove remaining uses and the files

(In reply to comment #4)
> Looks good.  r=edburns for the PlugletsDir.cpp code.
> 
> I actually have that file modified in my workspace now.  Do you want me to just
> take your patch and incorporate it into my modified file or do you want to
> check it in and I'll do the merge?

Thanks for that, I'll check it in tomorrow with the rest of the patch.

Comment 6

[Mark Banner (:standard8)]

Patch checked in (without mozilla/java/xpcom changes as per comment 2) -> Fixed.