2D canvases appear upside down on OS/2

VERIFIED FIXED

Status

()

Core
Canvas: 2D
VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: Peter Weilbacher, Assigned: Peter Weilbacher)

Tracking

({verified1.8.1.1})

Trunk
x86
OS/2
verified1.8.1.1
Points:
---
Bug Flags:
blocking1.8.1.1 +

Firefox Tracking Flags

(Not tracked)

Details

([Fx 2.0.0.1])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
The canvas that is created by the SeaMonkey tab tooltips as well as the canvases that the Firefox Showcase extension creates of normal webpages appear upside down on OS/2 when built with SVG/Canvas support. Canvases created of images have the right orientation.

This is true for both trunk and 1.8 branch.
(Assignee)

Comment 1

11 years ago
Created attachment 237548 [details] [diff] [review]
Make for loop order dependent on platform

I wasn't very lucky with my fixes today, but I am going to try this last one. At least it works, even though it doesn't look very nice. But just wrapping the for line itself into #ifdefs breaks my syntax hightlighting...
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Attachment #237548 - Flags: superreview?
Attachment #237548 - Flags: review?
(Assignee)

Comment 2

11 years ago
Comment on attachment 237548 [details] [diff] [review]
Make for loop order dependent on platform

This time really ask for reviews...
Attachment #237548 - Flags: superreview?(roc)
Attachment #237548 - Flags: superreview?
Attachment #237548 - Flags: review?(vladimir)
Attachment #237548 - Flags: review?
I think you should create a new #define up around here:
http://lxr.mozilla.org/seamonkey/source/content/canvas/src/nsCanvasRenderingContext2D.cpp#2726
say NATIVE_SURFACE_IS_VERTICALLY_FLIPPED
and define it for OS/2 only, then test that in the code.
(Assignee)

Comment 4

11 years ago
Created attachment 238304 [details] [diff] [review]
Improved patch

roc, thanks for the comment. This new patch takes it into account. Instead of messing with the for-loop start and end values it also seemed better to me to just reverse the one instance where the loop variable is used.
Attachment #237548 - Attachment is obsolete: true
Attachment #238304 - Flags: superreview?(roc)
Attachment #238304 - Flags: review?(vladimir)
Attachment #237548 - Flags: superreview?(roc)
Attachment #237548 - Flags: review?(vladimir)
Attachment #238304 - Flags: review?(vladimir) → review+
Attachment #238304 - Flags: superreview?(roc) → superreview+
(Assignee)

Comment 5

11 years ago
Checked into trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

11 years ago
Comment on attachment 238304 [details] [diff] [review]
Improved patch

I realize that it's late but in my mind it is pretty important for OS/2 to get this into branch (SeaMonkey uses the Canvas feature directly, and there are some popular Firefox extensions out there, too).
As it is OS/2 only and has been on trunk for a few days without adverse effects, I don't think it would disturb the release process.
Attachment #238304 - Flags: approval1.8.1?
Already spinning RC2 builds, so the branch is closed and frozen atm ...
Flags: blocking1.8.1.1?
Whiteboard: [Fx 2.0.0.1]
Attachment #238304 - Flags: approval1.8.1? → approval1.8.1-
(Assignee)

Comment 8

11 years ago
Comment on attachment 238304 [details] [diff] [review]
Improved patch

OS/2 only fix, trunk tested.
Attachment #238304 - Flags: approval1.8.1.1?
Comment on attachment 238304 [details] [diff] [review]
Improved patch

approved for 1.8 branch, a=dveditz for drivers
Attachment #238304 - Flags: approval1.8.1.1? → approval1.8.1.1+
Flags: blocking1.8.1.1? → blocking1.8.1.1+
(Assignee)

Comment 10

10 years ago
Checked into branch.
Keywords: fixed1.8.1.1
(Assignee)

Comment 11

10 years ago
Verifying some older bugs.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.1 → verified1.8.1.1
You need to log in before you can comment on or make changes to this bug.