The canvas that is created by the SeaMonkey tab tooltips as well as the canvases that the Firefox Showcase extension creates of normal webpages appear upside down on OS/2 when built with SVG/Canvas support. Canvases created of images have the right orientation. This is true for both trunk and 1.8 branch.
Created attachment 237548 [details] [diff] [review] Make for loop order dependent on platform I wasn't very lucky with my fixes today, but I am going to try this last one. At least it works, even though it doesn't look very nice. But just wrapping the for line itself into #ifdefs breaks my syntax hightlighting...
Comment on attachment 237548 [details] [diff] [review] Make for loop order dependent on platform This time really ask for reviews...
I think you should create a new #define up around here: http://lxr.mozilla.org/seamonkey/source/content/canvas/src/nsCanvasRenderingContext2D.cpp#2726 say NATIVE_SURFACE_IS_VERTICALLY_FLIPPED and define it for OS/2 only, then test that in the code.
Created attachment 238304 [details] [diff] [review] Improved patch roc, thanks for the comment. This new patch takes it into account. Instead of messing with the for-loop start and end values it also seemed better to me to just reverse the one instance where the loop variable is used.
Checked into trunk.
Comment on attachment 238304 [details] [diff] [review] Improved patch I realize that it's late but in my mind it is pretty important for OS/2 to get this into branch (SeaMonkey uses the Canvas feature directly, and there are some popular Firefox extensions out there, too). As it is OS/2 only and has been on trunk for a few days without adverse effects, I don't think it would disturb the release process.
Already spinning RC2 builds, so the branch is closed and frozen atm ...
Comment on attachment 238304 [details] [diff] [review] Improved patch OS/2 only fix, trunk tested.
Comment on attachment 238304 [details] [diff] [review] Improved patch approved for 1.8 branch, a=dveditz for drivers
Checked into branch.
Verifying some older bugs.