351986 - 2D canvases appear upside down on OS/2

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Peter Weilbacher]

The canvas that is created by the SeaMonkey tab tooltips as well as the canvases that the Firefox Showcase extension creates of normal webpages appear upside down on OS/2 when built with SVG/Canvas support. Canvases created of images have the right orientation.

This is true for both trunk and 1.8 branch.

Comment 1

[Peter Weilbacher]

Attachment: Make for loop order dependent on platform

I wasn't very lucky with my fixes today, but I am going to try this last one. At least it works, even though it doesn't look very nice. But just wrapping the for line itself into #ifdefs breaks my syntax hightlighting...

Comment 2

[Peter Weilbacher]

Comment on attachment 237548 [details] [diff] [review]
Make for loop order dependent on platform

This time really ask for reviews...

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think you should create a new #define up around here:
http://lxr.mozilla.org/seamonkey/source/content/canvas/src/nsCanvasRenderingContext2D.cpp#2726
say NATIVE_SURFACE_IS_VERTICALLY_FLIPPED
and define it for OS/2 only, then test that in the code.

Comment 4

[Peter Weilbacher]

Attachment: Improved patch

roc, thanks for the comment. This new patch takes it into account. Instead of messing with the for-loop start and end values it also seemed better to me to just reverse the one instance where the loop variable is used.

Comment 5

[Peter Weilbacher]

Checked into trunk.

Comment 6

[Peter Weilbacher]

Comment on attachment 238304 [details] [diff] [review]
Improved patch

I realize that it's late but in my mind it is pretty important for OS/2 to get this into branch (SeaMonkey uses the Canvas feature directly, and there are some popular Firefox extensions out there, too).
As it is OS/2 only and has been on trunk for a few days without adverse effects, I don't think it would disturb the release process.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Already spinning RC2 builds, so the branch is closed and frozen atm ...

Comment 8

[Peter Weilbacher]

Comment on attachment 238304 [details] [diff] [review]
Improved patch

OS/2 only fix, trunk tested.

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 238304 [details] [diff] [review]
Improved patch

approved for 1.8 branch, a=dveditz for drivers

Comment 10

[Peter Weilbacher]

Checked into branch.

Comment 11

[Peter Weilbacher]

Verifying some older bugs.