Closed Bug 352005 Opened 14 years ago Closed 13 years ago

Sunbird doesn't include view source support

Categories

(Calendar :: General, defect, major)

defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED
Sunbird 0.5

People

(Reporter: mattwillis, Assigned: mattwillis)

Details

Attachments

(3 files)

Sunbird doesn't include view source support.

Unfortunately, this means that when a user clicks a chrome:// link in the Error Console, no source editor pops up, but instead a warning about a missing toolkit xul file appears.... maybe.  The dialog is hidden and buried beneath a bunch of other windows.

On Mac, clicking on that chrome:// link adds two empty entries under the Window menu.  You have to close the Error Console to find the error message.

"Alert
The file
jar:file:///Users/mwillis/moz/printing/mozilla/obj-i386-apple-darwin8.7.1/dist/CalendarDebug.app/Contents/MacOS/chrome/toolkit.jar!/content/global/viewSource.xul
cannot be found. Please check the location and try again.


We need to remove "MOZ_VIEW_SOURCE= " from configure.in to fix this. The two lines that should be added to /m/cal/installer/windows/packages-static are already there.
Status: NEW → ASSIGNED
We should pick up MOZ_VIEW_SOURCE=1 from the defaults.

Requesting r1 from bsmedberg since we're touching configure.in.

We'll want to land this on 1.8.1 as well to keep things in sync, after baking it on trunk.
Attachment #237578 - Flags: second-review?(mvl)
Attachment #237578 - Flags: first-review?(benjamin)
Flags: blocking0.3?
We can live without this for 0.3
Flags: blocking0.3?
Flags: blocking0.3-
Comment on attachment 237578 [details] [diff] [review]
removes disabling of MOZ_VIEW_SOURCE=   from configure.in

r=mvl
Attachment #237578 - Flags: second-review?(mvl) → second-review+
Comment on attachment 237578 [details] [diff] [review]
removes disabling of MOZ_VIEW_SOURCE=   from configure.in

The closer we can get to the xulrunner platform defaults the happier I'll be.
Attachment #237578 - Flags: first-review?(benjamin) → first-review+
Patch checked in on trunk.

Will let bake before requesting a181.
Whiteboard: [baking until 9/14][needs a181]
On trunk with latest Sunbird nightly I get an Alert dialog "view-source is not a registered protocol" and the following error in the console:

Error: uncaught exception: [Exception... "Component returned failure code: 0x804b0012 [nsIWebNavigation.loadURI]"  nsresult: "0x804b0012 (<unknown>)"  location: "JS frame :: chrome://global/content/viewSource.js :: viewSource :: line 143"  data: no]
Target Milestone: Sunbird 0.3 → Sunbird 0.5
I forgot to add the protocol to our list.
Attachment #242136 - Flags: second-review?(dmose)
Attachment #242136 - Flags: first-review?(benjamin)
Additional prefs for view-source.
Omitting the find-bar one gives this exception:

JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getIntPref]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://global/content/findBar.js :: anonymous :: line 97"  data: no]
Attachment #242137 - Flags: first-review?(dmose)
Attachment #242136 - Flags: first-review?(benjamin) → first-review+
Comment on attachment 242136 [details] [diff] [review]
adds "viewsource" to the default necko protocols

r2=mvl
Attachment #242136 - Flags: second-review?(dmose) → second-review+
Comment on attachment 242137 [details] [diff] [review]
add'l prefs for view-source

r=mvl
Attachment #242137 - Flags: first-review?(dmose) → first-review+
Checked in on trunk. Baking before asking for a181
Baked. 
Landed on MOZILLA_1_8_BRANCH.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [baking until 9/14][needs a181]
VERIFIED with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070406 Calendar/0.5pre.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.