Closed
Bug 352005
Opened 15 years ago
Closed 14 years ago
Sunbird doesn't include view source support
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
VERIFIED
FIXED
Sunbird 0.5
People
(Reporter: mattwillis, Assigned: mattwillis)
Details
Attachments
(3 files)
688 bytes,
patch
|
benjamin
:
first-review+
mvl
:
second-review+
|
Details | Diff | Splinter Review |
780 bytes,
patch
|
benjamin
:
first-review+
mvl
:
second-review+
|
Details | Diff | Splinter Review |
850 bytes,
patch
|
mvl
:
first-review+
|
Details | Diff | Splinter Review |
Sunbird doesn't include view source support. Unfortunately, this means that when a user clicks a chrome:// link in the Error Console, no source editor pops up, but instead a warning about a missing toolkit xul file appears.... maybe. The dialog is hidden and buried beneath a bunch of other windows. On Mac, clicking on that chrome:// link adds two empty entries under the Window menu. You have to close the Error Console to find the error message. "Alert The file jar:file:///Users/mwillis/moz/printing/mozilla/obj-i386-apple-darwin8.7.1/dist/CalendarDebug.app/Contents/MacOS/chrome/toolkit.jar!/content/global/viewSource.xul cannot be found. Please check the location and try again. We need to remove "MOZ_VIEW_SOURCE= " from configure.in to fix this. The two lines that should be added to /m/cal/installer/windows/packages-static are already there.
Assignee | ||
Updated•15 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•15 years ago
|
||
We should pick up MOZ_VIEW_SOURCE=1 from the defaults. Requesting r1 from bsmedberg since we're touching configure.in. We'll want to land this on 1.8.1 as well to keep things in sync, after baking it on trunk.
Attachment #237578 -
Flags: second-review?(mvl)
Attachment #237578 -
Flags: first-review?(benjamin)
Assignee | ||
Updated•15 years ago
|
Flags: blocking0.3?
Updated•15 years ago
|
Flags: blocking0.3-
Comment 3•15 years ago
|
||
Comment on attachment 237578 [details] [diff] [review] removes disabling of MOZ_VIEW_SOURCE= from configure.in r=mvl
Attachment #237578 -
Flags: second-review?(mvl) → second-review+
Comment 4•15 years ago
|
||
Comment on attachment 237578 [details] [diff] [review] removes disabling of MOZ_VIEW_SOURCE= from configure.in The closer we can get to the xulrunner platform defaults the happier I'll be.
Attachment #237578 -
Flags: first-review?(benjamin) → first-review+
Assignee | ||
Comment 5•15 years ago
|
||
Patch checked in on trunk. Will let bake before requesting a181.
Whiteboard: [baking until 9/14][needs a181]
Comment 6•15 years ago
|
||
On trunk with latest Sunbird nightly I get an Alert dialog "view-source is not a registered protocol" and the following error in the console: Error: uncaught exception: [Exception... "Component returned failure code: 0x804b0012 [nsIWebNavigation.loadURI]" nsresult: "0x804b0012 (<unknown>)" location: "JS frame :: chrome://global/content/viewSource.js :: viewSource :: line 143" data: no]
Updated•15 years ago
|
Target Milestone: Sunbird 0.3 → Sunbird 0.5
Assignee | ||
Comment 7•15 years ago
|
||
I forgot to add the protocol to our list.
Attachment #242136 -
Flags: second-review?(dmose)
Attachment #242136 -
Flags: first-review?(benjamin)
Assignee | ||
Comment 8•15 years ago
|
||
Additional prefs for view-source. Omitting the find-bar one gives this exception: JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getIntPref]" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: chrome://global/content/findBar.js :: anonymous :: line 97" data: no]
Attachment #242137 -
Flags: first-review?(dmose)
Updated•14 years ago
|
Attachment #242136 -
Flags: first-review?(benjamin) → first-review+
Comment 9•14 years ago
|
||
Comment on attachment 242136 [details] [diff] [review] adds "viewsource" to the default necko protocols r2=mvl
Attachment #242136 -
Flags: second-review?(dmose) → second-review+
Comment 10•14 years ago
|
||
Comment on attachment 242137 [details] [diff] [review] add'l prefs for view-source r=mvl
Attachment #242137 -
Flags: first-review?(dmose) → first-review+
Assignee | ||
Comment 11•14 years ago
|
||
Checked in on trunk. Baking before asking for a181
Assignee | ||
Comment 12•14 years ago
|
||
Baked. Landed on MOZILLA_1_8_BRANCH. -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [baking until 9/14][needs a181]
Comment 13•14 years ago
|
||
VERIFIED with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070406 Calendar/0.5pre.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•