352015 - Missing parens in decompilation of "yield" expressions

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Jesse Ruderman]

js> version(170)
0

js> function() { (yield).a }
function () {
    yield.a;
}

js> function() { 3 + (yield 4) }
function () {
    3 + yield 4;
}

Comment 1

[Brendan Eich [:brendan]]

Attachment: fix

This means functon () { x = yield y; } will overparenthesize the RHS, but that's ok by me.  KISS.

/be

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 237589 [details] [diff] [review]
fix

Safe patch builds on the recent precedence reform, to automate parenthesization when decompiling.

/be

Comment 3

[Brendan Eich [:brendan]]

Fixed on trunk.

/be

Comment 4

[Brendan Eich [:brendan]]

*** Bug 352030 has been marked as a duplicate of this bug. ***

Comment 5

[Mike Schroepfer]

Comment on attachment 237589 [details] [diff] [review]
fix

a=schrep for js decompiler cleanup

Comment 6

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch.

/be

Comment 7

[Bob Clary [:bc] (inactive)]

Checking in js1_7/geniter/regress-352015.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/regress-352015.js,v  <--  regress-352015.js
initial revision: 1.1
done

Comment 8

[Bob Clary [:bc] (inactive)]

verified fixed 1.8 1.9 2006091022 windows/mac*/linux