352032 - A few prefs buttons lost their disable_button in the prefs reorg

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Phil Ringnalda (:philor)]

The prefs reorg slightly altered the slightly strange state of which buttons can be disabled with a locked pref.*.disable_button.* preference. "Main - Restore (home page) to default" and "Security - Password exceptions" are just missing their <preference> element, and "Content - File types" just needs someone to make a decision about whether to retain the (now incorrect) pref name "pref.downloads.disable_button.edit_actions" or change it to "pref.content...". Since at one point 2.0 was going to be a nearly-no-APIish-changes branch, leaving the name the same seems best.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Test .cfg

Because I keep forgetting how to test this, from one time I check on it to the next:

 - Drop this attachment in the main directory (with firefox.exe/firefox-bin) of a copy of the app that you'll blow away, since that's easier than cleaning up after it

 - edit greprefs/all.js, and add |pref("general.config.filename","mozilla.cfg");| to it

 - start up with a profile you'll also blow away

Expected:

Main tab, "Restore to Default" disabled
Content tab, "Manage..." disabled
Security tab, "Exceptions..." (in row with "Remember passwords for sites") disabled

Comment 3

[Phil Ringnalda (:philor)]

browser/components/preferences/content.xul 1.20
browser/components/preferences/main.xul 1.11
browser/components/preferences/security.xul 1.13