352054 - Browse button direction should always match its default text

Status: RESOLVED INCOMPLETE

(Core :: Internationalization: Localization, defect)

Description

[Niro]

"Browse..." button (of <input type="file">) has netural characters ("...") so the position of the periods depends on the inherited direction.

see the upcoming testcase.

Comment 1

[Niro]

Attachment: testcase

Comment 2

[Behnam Esfahbod [:zwnj]]

IMO translations should to fix the problem in the branch.

Pike, do you accept patch?

Comment 3

[Axel Hecht [:Pike]]

Unlikely, and surely not before I've seen it do something useful on the trunk.

Comment 4

[Behnam Esfahbod [:zwnj]]

The right way to get it fixed is to use the documents language for the button, and it's direction and alignment.  It has been discussed on bug 347515.

But for the branch, seems the simplest way to fix the problem is to force put LRM/RLM after the "..." in all translations (and in en-US as well).  Of course, it's not a complete solution, as you will give English "Browse..." on a Persian site yet, but at least, you will see "Browse...", not "...Browse".

Comment 5

[Axel Hecht [:Pike]]

(In reply to comment #4)
> The right way to get it fixed is to use the documents language for the button,
> and it's direction and alignment.  It has been discussed on bug 347515.

In mixed content, I'm not convinced..

> But for the branch, seems the simplest way to fix the problem is to force put
> LRM/RLM after the "..." in all translations (and in en-US as well).  Of course,
> it's not a complete solution, as you will give English "Browse..." on a Persian
> site yet, but at least, you will see "Browse...", not "...Browse".
> 

Not gonna fix that one for Firefox 2. To take changes as large as this in string freeze a day before RC1 lock-down, this had to be a major regression, this is merely not pretty.

Comment 6

[Gordon P. Hemsley [:GPHemsley]]

What's the status of this? I know there's currently some file that specifically localizes the ellipsis. Could that be (or is it) used for this?

Comment 7

[Axel Hecht [:Pike]]

I don't think this has something to do with the ellipis, that entity is more ... vs … vs the middle-aligned ones.

I think the issue has something to do with the text direction of the document vs the widget.

Comment 8

[Boris Zbarsky [:bzbarsky]]

We don't really have a good setup for localizing that sort of thing.  :(  We could hack something in, I guess...  Would it be better than using LRM/RLM?

Comment 9

[Tomer Cohen :tomer]

We had some progress on bug 668964, so it might be good idea to make this bug a dupe of bug 668964. 

Because we don't have a fix to this issue (but have a patch ready thanks to Ehsan!), we have landed in the meantime "browse…[RLM]" string in Hebrew (and I hope that other RTL locales have similar workarounds as well). This is ugly hack and I hope that one day we could remove it.

Comment 10

[(no longer active)]

I think we would want to morph this bug to cover what Behnam mentioned in comment 4.  Boris, do you agree?

Comment 11

[Boris Zbarsky [:bzbarsky]]

I'm not quite sure what comment 4 is proposing in terms of direction styling... Is the proposal to base it on the computed lang of the button with some sort of lang-to-direction mapping?

Comment 12

[(no longer active)]

We should ideally get the text for the Browse button from the lang of the node, and then use dir=auto to render the text, I think.

Comment 13

[Francesco Lodolo [:flod]]

Feel free to reopen and move if this is still actionable/valid.