Closed
Bug 352128
Opened 18 years ago
Closed 17 years ago
sq - Albanian Search feature tracking for Firefox 2
Categories
(Mozilla Localizations :: sq / Albanian, defect)
Mozilla Localizations
sq / Albanian
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: besnik)
References
Details
Attachments
(3 files)
1.24 KB,
text/html
|
Details | |
152 bytes,
patch
|
Details | Diff | Splinter Review | |
1.80 KB,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
Albanian used the en-US search plugins in 1.5, and does so in 2.0, which is fine.
dictionary needs to be removed, though, as we're not shipping that anymore.
Reporter | ||
Updated•18 years ago
|
Blocks: fx20search
Reporter | ||
Comment 1•17 years ago
|
||
Mic, Besnik doesn't have splendid ideas for local search engines for Albanian, I'm not dead-on surprised. Any ideas on your side or should we just leave things en-US?
We could do sq.wikipedia.org, it's in the 10.000+ category.
Same goes probably for feed readers.
Besnik, any idea for a good newsfeed in Albanian, or for Albania?
Comment 2•17 years ago
|
||
hi
agree to add sq.wikipedia.org
also - i just received an int'l search engine report - i'll look to see if they list anything.
mic
Assignee | ||
Comment 3•17 years ago
|
||
I would be tempted to finally make people from BBC happy, including their feed or another blog but have doubts of using them...That could be interpreted as taking one´s part.Any hint?
Assignee | ||
Comment 4•17 years ago
|
||
BBC´s feed in Albanian, http://feeds.bbc.co.uk/albanian/index.xml, would be a good choice.
Reporter | ||
Comment 5•17 years ago
|
||
Besnik, any opinion on sq.wikipedia.org?
Assignee | ||
Comment 6•17 years ago
|
||
sq.wikipedia.org is in a prety good shape, in terms of localization. Including it wouldn't harm anything.
Reporter | ||
Comment 7•17 years ago
|
||
Mind attaching a patch and requesting review from me for that then?
http://wiki.mozilla.org/Firefox3/L10n_Requirements#Wikipedia has the specs, http://mxr.mozilla.org/l10n/source/lv/browser/searchplugins/wikipedia-en.xml is an example.
wikipedia-sq.xml would be a good name, the patch should include both the added file and the change to list.txt.
Assignee | ||
Comment 8•17 years ago
|
||
Assignee | ||
Comment 9•17 years ago
|
||
Axel,
could you please check both the file and the patch?
Reporter | ||
Comment 10•17 years ago
|
||
That looks ok, you'd create the real patch with
cvs add wikipedia-sq.xml
cvs -z3 diff -uN
The cvs add just add the file locally, and doesn't touch the server just yet, so that's fine to do upfront.
Can you create that, and then set the 'r' flag on that attachment to '?' and the requestee to l10n@mozilla.com?
Assignee | ||
Comment 11•17 years ago
|
||
Pike, I followed your last instructions. I don't know if cvs -z3 diff -uN was supposed to act remotely or I needed that to locally creat a patch. Si I did/faked both. Here you are the patch created locally.
Attachment #294031 -
Flags: review?(l10n)
Assignee | ||
Comment 12•17 years ago
|
||
Would you approve a patch for the shortkeys and accesskeys? I need to know before I spend two days fighting with them. Or the above patch is enough to get sq from incubatory, so I can continue with FF3?
Reporter | ||
Updated•17 years ago
|
Attachment #294031 -
Attachment is patch: true
Attachment #294031 -
Attachment mime type: application/octet-stream → text/plain
Reporter | ||
Comment 13•17 years ago
|
||
Comment on attachment 294031 [details] [diff] [review]
patch for wikipedia-sq.xml and list.txt
r=me. Please check this in with a comment referencing this bug and my review. Something like "bug 352128, add Wikipedia (SQ), r=l10n@mozilla.com" would be a standard way to do this.
Regarding your accesskey question, patches like that don't need approval as long as you're checking in on trunk (might change in preperation for fx3). If you'd want to branch and then land that patch, you'd have to request approval for that.
Attachment #294031 -
Flags: review?(l10n) → review+
Updated•17 years ago
|
Whiteboard: needs-landing
Assignee | ||
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 14•17 years ago
|
||
Looking at it, and at this bug, we totally forgot about RSS feed readers.
http://bonsai-l10n.mozilla.org/cvsblame.cgi?file=/l10n/sq/browser/chrome/browser-region/region.properties&rev=1.3
doesn't specify any, which is not good, reopening.
Sorry for that, we're much better at filing these bugs today.
I doubt there is a whole lot of localized feed readers for Albanian? Netvibes seems to be available, so maybe add that?
Basically, you want to add the block of http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/locales/en-US/chrome/browser-region/region.properties&rev=1.9.2.15&mark=9-14
I'd suggest replacing bloglines with netvibes.
Catalan just added netvibes as first, see http://bonsai-l10n.mozilla.org/cvsblame.cgi?file=/l10n/ca/browser/chrome/browser-region/region.properties.
Mic?
(Unhooking the dependency on that old fx2 search tracker for sanity)
Reporter | ||
Updated•17 years ago
|
Whiteboard: needs-landing → needs-patch
Reporter | ||
Comment 15•17 years ago
|
||
Besnik just reverted the entries to en-US for now. Closing this bug again.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Whiteboard: needs-patch
You need to log in
before you can comment on or make changes to this bug.
Description
•