352248 - should make it clear what is public and what's not in head.js

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Nickolay_Ponomarev]

For example, do_check_eq is public, while do_main and do_quit are not.

Comment 1

[Nickolay_Ponomarev]

Attachment: patch

This fixed the mentioned problem, updates the doc link to point to MDC, and fixes the problem with DEPTH I mentioned earlier.

Comment 2

[Dave Liebreich [:davel]]

Comment on attachment 237859 [details] [diff] [review]
patch

did you run "make check" after applying this patch to a tree, and check for failures?

Also, DEPTH needs to be set depending on where this example Makefile.in is instantiated in the tree.  Is there some text we could put in there that would instruct the test writer to "%REPLACE_ME%" with the correct number of ../'s?

Comment 3

[Nickolay_Ponomarev]

I've ran netwerk tests before attaching the patch and now the complete 'make check' per your request. Yes, they don't fail.

We could (in order of developer-friendliness):
- add a few comments to the files that are part of the example explaining what can be changed and what should be done.
- just link to the docs from all the files
- leave it as is, since example's Readme already contains a link to the docs.

I changed DEPTH just to confuse people less. If you think more comments are needed, I can do it in a separate bug.

Comment 4

[Dave Liebreich [:davel]]

Comment on attachment 237859 [details] [diff] [review]
patch

ok.  Please open another bug to more clearly mark the parts of the example makefile that need to be customized.

Comment 5

[Dave Liebreich [:davel]]

Checking in xpcshell-simple/README;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/README,v  <--  README
new revision: 1.2; previous revision: 1.1
done
Checking in xpcshell-simple/head.js;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/head.js,v  <--  head.js
new revision: 1.5; previous revision: 1.4
done
Checking in xpcshell-simple/tail.js;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/tail.js,v  <--  tail.js
new revision: 1.2; previous revision: 1.1
done
Checking in xpcshell-simple/example/Makefile.in;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/example/Makefile.in,v  <--  Makefile.in
new revision: 1.2; previous revision: 1.1
done

Comment 6

[Jeff Walden [:Waldo]]

Comment on attachment 237859 [details] [diff] [review]
patch

>Index: tools/test-harness/xpcshell-simple/head.js

>+ * for more informaton

Could someone with more time than me fix this, please?  :-)

Comment 7

[Nickolay_Ponomarev]

D'oh!

BTW, I filed bug 352305 for the issue raised in comment 2, as requested.

Comment 8

[Dave Liebreich [:davel]]

fixed typo

/cvsroot/mozilla/tools/test-harness/xpcshell-simple/head.js,v  <--  head.js
new revision: 1.6; previous revision: 1.5
done

(thanks for catching this)

Comment 9

[Nickolay_Ponomarev]

Thanks Dave, and sorry for the trouble.