If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

should make it clear what is public and what's not in head.js

RESOLVED FIXED

Status

Testing
XPCShell Harness
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: Nickolay_Ponomarev, Assigned: Nickolay_Ponomarev)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
For example, do_check_eq is public, while do_main and do_quit are not.
(Assignee)

Comment 1

11 years ago
Created attachment 237859 [details] [diff] [review]
patch

This fixed the mentioned problem, updates the doc link to point to MDC, and fixes the problem with DEPTH I mentioned earlier.
Attachment #237859 - Flags: review?(davel)
Comment on attachment 237859 [details] [diff] [review]
patch

did you run "make check" after applying this patch to a tree, and check for failures?

Also, DEPTH needs to be set depending on where this example Makefile.in is instantiated in the tree.  Is there some text we could put in there that would instruct the test writer to "%REPLACE_ME%" with the correct number of ../'s?
(Assignee)

Comment 3

11 years ago
I've ran netwerk tests before attaching the patch and now the complete 'make check' per your request. Yes, they don't fail.

We could (in order of developer-friendliness):
- add a few comments to the files that are part of the example explaining what can be changed and what should be done.
- just link to the docs from all the files
- leave it as is, since example's Readme already contains a link to the docs.

I changed DEPTH just to confuse people less. If you think more comments are needed, I can do it in a separate bug.
Comment on attachment 237859 [details] [diff] [review]
patch

ok.  Please open another bug to more clearly mark the parts of the example makefile that need to be customized.
Attachment #237859 - Flags: review?(davel) → review+
Checking in xpcshell-simple/README;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/README,v  <--  README
new revision: 1.2; previous revision: 1.1
done
Checking in xpcshell-simple/head.js;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/head.js,v  <--  head.js
new revision: 1.5; previous revision: 1.4
done
Checking in xpcshell-simple/tail.js;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/tail.js,v  <--  tail.js
new revision: 1.2; previous revision: 1.1
done
Checking in xpcshell-simple/example/Makefile.in;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/example/Makefile.in,v  <--  Makefile.in
new revision: 1.2; previous revision: 1.1
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Comment on attachment 237859 [details] [diff] [review]
patch

>Index: tools/test-harness/xpcshell-simple/head.js

>+ * for more informaton

Could someone with more time than me fix this, please?  :-)
(Assignee)

Comment 7

11 years ago
D'oh!

BTW, I filed bug 352305 for the issue raised in comment 2, as requested.
fixed typo

/cvsroot/mozilla/tools/test-harness/xpcshell-simple/head.js,v  <--  head.js
new revision: 1.6; previous revision: 1.5
done

(thanks for catching this)
(Assignee)

Comment 9

11 years ago
Thanks Dave, and sorry for the trouble.
Component: Testing → TUnit
Product: Core → Testing
QA Contact: testing → tunit
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.