352281 - Round-trip bracing change with "while" and function declaration

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

js> p = function() { { while(0) function t() {  } } }
function () {
    {
        while (0) {

            function t() {
            }

        }
    }
}

js> eval("" + p)
function () {
    while (0) {

        function t() {
        }

    }
}

Comment 1

[Brendan Eich [:brendan]]

Superfluous braces are not preserved.  Doing so costs extra bytecode (NOP at least) and source note space and code complexity.  I would like to WONTFIX this.  Jesse, what do you say?

/be

Comment 2

[Brendan Eich [:brendan]]

Duh, superfluous braces are preserved, as the first shell result shows.  Should be easy to fix.

/be

Comment 3

[Brendan Eich [:brendan]]

Attachment: fix

Comment 4

[Brendan Eich [:brendan]]

Fixed on trunk.

/be

Comment 5

[Mike Schroepfer]

Comment on attachment 238029 [details] [diff] [review]
fix

a=schrep for 181drivers for JS decompiler fuzz bugs.

Comment 6

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch.

/be

Comment 7

[Bob Clary [:bc] (inactive)]

Checking in regress-352281.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-352281.js,v  <--  regress-352281.js
initial revision: 1.1
done

Comment 8

[Bob Clary [:bc] (inactive)]

verified fixed 1.8 20060914 windows/linux 1.9 20060914 windows/mac*/linux