352426 - decide whether or not to allow not-opened channels in nsICharsetResolver API

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Embedding: APIs, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

>+      var charset = resolver.requestCharset(null, request.channel, {}, {});

bzbarsky notes:

Strictly speaking, this [use of nsICharsetResolver] is abuse of the API, if the channel hasn't sent onStartRequest yet... At least as the API was initially created.  You might want to file another bug on clarifying that sitation; I have no problem with allowing not-opened channels in this API, in general...

Should we allow not-opened channels in this API or not?

Comment 1

[Boris Zbarsky [:bzbarsky]]

biesi, darin.... is there a way to tell a not-yet-opened channel apart from an already-done (and hence not pending) one?  If not, then allowing not-opened channels means basically saying that only the URI matters, in which case we might as well pass in a URI...

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

I can't currently think of a generic way for that... hacks are possible for certain channel types, of course.

Comment 3

[Benjamin Smedberg]

Marking a bunch of bugs in the "Embedding: APIs" component INCOMPLETE in preparation to archive that component. If I have done this incorrectly, please reopen the bugs and move them to a more correct component as we don't have "embedding" APIs any more.