Closed
Bug 352431
Opened 18 years ago
Closed 18 years ago
Version bump for 2.0rc1
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: preed, Assigned: preed)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
3.03 KB,
patch
|
robert.strong.bugs
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
For the upcoming RC1, we need to bump the version number, check official branding, and make sure all the build infrastructure is pulling the right versions (l10n, AUS, AMO, etc.) Unless someone else wants to, build/release can take care of the bump + the associated verification to make sure the bump propagates through the build system correctly. I can take it for now, but if someone else needs to check something/do this, feel free to re-assign.
Assignee | ||
Updated•18 years ago
|
Flags: blocking-firefox2?
Comment 1•18 years ago
|
||
We should be able to just go ahead and change this whenever you have cycles.
Flags: blocking-firefox2? → blocking-firefox2+
Updated•18 years ago
|
Hardware: PC → All
Updated•18 years ago
|
Target Milestone: --- → Firefox 2
Assignee | ||
Comment 2•18 years ago
|
||
Attachment #238305 -
Flags: review?(robert.bugzilla)
Updated•18 years ago
|
Attachment #238305 -
Flags: review?(robert.bugzilla) → review+
Assignee | ||
Updated•18 years ago
|
Attachment #238305 -
Flags: approval1.8.1?
Comment 3•18 years ago
|
||
Comment on attachment 238305 [details] [diff] [review] Bump version for rc1 a=mconnor on behalf of drivers for 1.8 branch checkin
Attachment #238305 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Comment 4•18 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•18 years ago
|
Keywords: fixed1.8.1
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060914 BonEcho/2.0 ID:2006091402 rv in UA is still "1.8.1b2".
Comment 6•18 years ago
|
||
I just updated to today's nightly builds, and the user-agent looks ok to me: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1) Gecko/20060914 BonEcho/2.0 However, the application is still "BonEcho"... do we want to make that "Firefox" yet? Since the app version is now 2.0 (since we're at rc1), just want to make sure we don't miss anything.
Assignee | ||
Comment 7•18 years ago
|
||
(In reply to comment #6) > However, the application is still "BonEcho"... do we want to make that > "Firefox" yet? Since the app version is now 2.0 (since we're at rc1), just > want to make sure we don't miss anything. I'll let mconnor confirm, but I think we will want to change this to Firefox when we're code complete, since the release should have Firefox/2.0 at the end of the user agent. I think? I can whip up a patch for it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 8•18 years ago
|
||
Is this part of official branding switches? If so we want to only flip it for those... (In reply to comment #7) > (In reply to comment #6) > > > However, the application is still "BonEcho"... do we want to make that > > "Firefox" yet? Since the app version is now 2.0 (since we're at rc1), just > > want to make sure we don't miss anything. > > I'll let mconnor confirm, but I think we will want to change this to Firefox > when we're code complete, since the release should have Firefox/2.0 at the end > of the user agent. I think? > > I can whip up a patch for it. >
Assignee | ||
Comment 9•18 years ago
|
||
(In reply to comment #8) > Is this part of official branding switches? If so we want to only flip it for > those... Looks like it might be. I didn't look closely enough at configure.in. I'll confirm with :rs.
Comment 10•18 years ago
|
||
-enable-official-branding should be all that is needed to change Bon Echo to Firefox, etc. One easy way to check is if the icon isn't the official icon.
Assignee | ||
Comment 11•18 years ago
|
||
Looks like this was fixed after all; reclosing.
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•