352447 - move "Show Passwords" button to RHS, add "Clear Now" for cache

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

A couple of preference panel cleanups with no l10n effects:

 - move the "Show Passwords" button to be right-aligned like the other buttons
 - add a "Clear Now" button to Advanced > Network > Cache

Patch pending.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: moves and adds buttons

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: moves and adds buttons, function to js file

Apparently this works better when the function I call, you know, actually exists. This time I actually tested it and it does, indeed, clear the cache.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Gavin points out that the button doesn't really give any feedback that it's done anything at all. Lucy points out that this is also true of the "Clear Now" button. I think a good (if somewhat fake) solution for this would be to disable the button after it's clicked, but re-enable it when the prefwindow blurs, as until that point it would be impossible to reaccumulate private data. If there's a better way to listen for changes to cache/private data entries, that would be even better.

Either way, that feels like a separate bug.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 238135 [details] [diff] [review]
moves and adds buttons, function to js file

>Index: browser/components/preferences/advanced.js

>+  clearCache: function ()
>+  {
>+    const cc = Components.classes;
>+    const ci = Components.interfaces;
>+    var cacheService = cc["@mozilla.org/network/cache-service;1"]
>+                         	.getService(ci.nsICacheService);
>+    try {
>+      cacheService.evictEntries(ci.nsICache.STORE_ANYWHERE);
>+    } catch(er) {}
>+  },

I'll fix a little style nit here on checkin.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: as checked in

mozilla/browser/components/preferences/security.xul 	1.12
mozilla/browser/components/preferences/advanced.xul 	1.34
mozilla/browser/components/preferences/advanced.js 	1.26

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Drivers: low risk fix for medium gain usability increase. The patch contains some absolutely safe XUL changes and also copies an existing function (for cache clearing) into advanced.js to allow us to clear the cache from the prefpane; this makes the task of clearing the cache much easier for web developers and other users who must do it often. Adding new code, not changing existing, so there's no chance of causing regressions in other areas.

Comment 7

[Mike Schroepfer]

Comment on attachment 238160 [details] [diff] [review]
as checked in

a=schrep for 181drivers for functional regression (clear cache now) from 1.5.x

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/preferences/security.xul 	1.5.2.7
mozilla/browser/components/preferences/advanced.xul 	1.17.2.19
mozilla/browser/components/preferences/advanced.js 	1.15.2.12