Closed
Bug 352592
Opened 19 years ago
Closed 19 years ago
moz:distributionID should not be hardcoded into nsSearchService.js
Categories
(Firefox :: Search, defect, P1)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: benjamin, Assigned: benjamin)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
1.64 KB,
patch
|
Gavin
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
moz:distributionID should not be hardcoded into nsSearchService.js but loaded from a pref, so that partner extensions can modify it sanely.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #238327 -
Flags: review?(gavin.sharp)
Attachment #238327 -
Flags: approval1.8.1?
|
|
Assignee | |
Updated•19 years ago
|
Flags: blocking-firefox2?
Priority: -- → P1
|
||
Comment 2•19 years ago
|
||
Comment on attachment 238327 [details] [diff] [review]
distributionID pref, rev. 1
Hrm, getting the pref each time ParamSubstitution is called is sub-optimal, but fine for now I guess.
Attachment #238327 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Comment 4•19 years ago
|
||
Comment on attachment 238327 [details] [diff] [review]
distributionID pref, rev. 1
a=mconnor on behalf of drivers for 1.8 branch checkin
Attachment #238327 -
Flags: approval1.8.1? → approval1.8.1+
|
|
||
Updated•19 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
You need to log in
before you can comment on or make changes to this bug.
Description
•