Closed Bug 352728 Opened 18 years ago Closed 18 years ago

[FIX]createComment, createProcessingInstruction and createCDATASection need to check their arguments for invalid strings

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: peterv, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

The DOM spec doesn't talk about this, but we should probably throw INVALID_CHARACTER_ERR in:

- createComment for - not followed by a character other than -
- createProcessingInstruction for data containing ?>
- createCDATASection for ]]>

Otherwise we'll create unserializable documents.
Attached patch FixSplinter Review
Attachment #245742 - Flags: superreview?(peterv)
Attachment #245742 - Flags: review?(peterv)
Assignee: general → bzbarsky
Priority: -- → P2
Summary: createComment, createProcessingInstruction and createCDATASection need to check their arguments for invalid strings → [FIX]createComment, createProcessingInstruction and createCDATASection need to check their arguments for invalid strings
Target Milestone: --- → mozilla1.9alpha
Attachment #245742 - Flags: superreview?(peterv)
Attachment #245742 - Flags: superreview+
Attachment #245742 - Flags: review?(peterv)
Attachment #245742 - Flags: review+
Fixed.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
QA Contact: ian → general
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: