Closed
Bug 352728
Opened 18 years ago
Closed 18 years ago
[FIX]createComment, createProcessingInstruction and createCDATASection need to check their arguments for invalid strings
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: peterv, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
14.64 KB,
patch
|
peterv
:
review+
peterv
:
superreview+
|
Details | Diff | Splinter Review |
The DOM spec doesn't talk about this, but we should probably throw INVALID_CHARACTER_ERR in:
- createComment for - not followed by a character other than -
- createProcessingInstruction for data containing ?>
- createCDATASection for ]]>
Otherwise we'll create unserializable documents.
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #245742 -
Flags: superreview?(peterv)
Attachment #245742 -
Flags: review?(peterv)
|
|
Assignee | |
Updated•18 years ago
|
Assignee: general → bzbarsky
Priority: -- → P2
Summary: createComment, createProcessingInstruction and createCDATASection need to check their arguments for invalid strings → [FIX]createComment, createProcessingInstruction and createCDATASection need to check their arguments for invalid strings
Target Milestone: --- → mozilla1.9alpha
|
Reporter | |
Updated•18 years ago
|
Attachment #245742 -
Flags: superreview?(peterv)
Attachment #245742 -
Flags: superreview+
Attachment #245742 -
Flags: review?(peterv)
Attachment #245742 -
Flags: review+
|
|
Assignee | |
Comment 2•18 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 3•18 years ago
|
||
http://lxr.mozilla.org/mozilla/source/testing/mochitest/tests/test_bug352728.xhtml
http://lxr.mozilla.org/mozilla/source/testing/mochitest/tests/test_bug352728.html
Flags: in-testsuite+
|
||
Updated•14 years ago
|
QA Contact: ian → general
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•