[FIX]createComment, createProcessingInstruction and createCDATASection need to check their arguments for invalid strings

RESOLVED FIXED in mozilla1.9alpha1

Status

()

P2
normal
RESOLVED FIXED
12 years ago
8 years ago

People

(Reporter: peterv, Assigned: bzbarsky)

Tracking

Trunk
mozilla1.9alpha1
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
The DOM spec doesn't talk about this, but we should probably throw INVALID_CHARACTER_ERR in:

- createComment for - not followed by a character other than -
- createProcessingInstruction for data containing ?>
- createCDATASection for ]]>

Otherwise we'll create unserializable documents.
(Assignee)

Comment 1

12 years ago
Created attachment 245742 [details] [diff] [review]
Fix
Attachment #245742 - Flags: superreview?(peterv)
Attachment #245742 - Flags: review?(peterv)
(Assignee)

Updated

12 years ago
Assignee: general → bzbarsky
Priority: -- → P2
Summary: createComment, createProcessingInstruction and createCDATASection need to check their arguments for invalid strings → [FIX]createComment, createProcessingInstruction and createCDATASection need to check their arguments for invalid strings
Target Milestone: --- → mozilla1.9alpha
(Reporter)

Updated

12 years ago
Attachment #245742 - Flags: superreview?(peterv)
Attachment #245742 - Flags: superreview+
Attachment #245742 - Flags: review?(peterv)
Attachment #245742 - Flags: review+
(Assignee)

Comment 2

12 years ago
Fixed.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

8 years ago
Depends on: 412257
QA Contact: ian → general
You need to log in before you can comment on or make changes to this bug.