352748 - Can't use JS 1.7 let/yield in JS components

Status: VERIFIED FIXED

(Core :: XPConnect, defect, P2)

Description

[nanto_vi (TOYAMA Nao)]

Confirmed in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060914 Minefield/3.0a1
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20060914 BonEcho/2.0

It seems that this bug is fixed in ZAP_20050610_BRANCH.
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp&rev=1.105.2.19&root=/cvsroot#460

Comment 1

[nanto_vi (TOYAMA Nao)]

I checked all the XPIs under http://releases.mozilla.org/pub/mozilla.org/extensions/ and no JS component in them uses let or yield as a variable name.  Flashgot 0.5.96 uses yield as a method name but it is treated as an identifier because it appears in an object initialiser.  So I think the risk of enabling JS 1.7 in JS components is low, or zero if only using extensions provided in addons.mozilla.org.

Now there is no way to use JS 1.7 let/yield in JS components.  Why not make JS 1.7 a new feature of Firefox 2 for extension developers?

Comment 2

[Brendan Eich [:brendan]]

Sorry, I lost track of this amid all the decompiler fixing.  We should fix this in an RC3 if there is an RC3.  Patch in a few, could use testing help.

/be

Comment 3

[Brendan Eich [:brendan]]

Attachment: fix from the ZAP_20050610_BRANCH change

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 241394 [details] [diff] [review]
fix from the ZAP_20050610_BRANCH change

r+sr=jst

Comment 5

[Brendan Eich [:brendan]]

Fixed on the trunk:

Checking in mozJSComponentLoader.cpp;
/cvsroot/mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp,v  <--  mozJSComponentLoader.cpp
new revision: 1.127; previous revision: 1.126
done

/be

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #2)
> Sorry, I lost track of this amid all the decompiler fixing.  We should fix this
> in an RC3 if there is an RC3.  Patch in a few, could use testing help.

Without this, is JS 1.7 actually implemented in a useful way in Firefox 2? I guess what I'm asking is, should this *cause* an RC3?

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocking for Fx2 RC3

Comment 8

[Mike Schroepfer]

Comment on attachment 241394 [details] [diff] [review]
fix from the ZAP_20050610_BRANCH change

Approved for RC3.

Comment 9

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch:

Checking in mozJSComponentLoader.cpp;
/cvsroot/mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp,v  <--  mozJSComponentLoader.cpp
new revision: 1.109.2.7; previous revision: 1.109.2.6
done

/be

Comment 10

[Bob Clary [:bc] (inactive)]

nanto, can you verify that this is fixed on 1.8?

Comment 11

[nanto_vi (TOYAMA Nao)]

Verified fixed 1.8 2006101103 Windows, 1.9 2006101104 Windows.