352774 - "Select..." in feed reader selection menu should use ellipsis, not 3 periods

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment 1

[Stuart Morgan]

This is just another Localizable.strings string that was forgotten in the RSS landing.

Someone with checkin privs just needs to add:
"Select..." = "Select…";
to the /* feed detection */ section of the main Localizable.strings file. It doesn't need r/sr, since it's just a missing piece of an approved patch.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

So the "Select..." string that's in the prefPane nib is unused "dummy" text (Navigation's Localizable.strings already includes that string), or is that menu not actually using the localized string like the OpenFeed nib?

Comment 3

[Stuart Morgan]

I thought this was about the window that pops up if you try to view a feed and don't have one selected, which should be drawing from the main application's strings file. It's possible that the way things are set up with that menu building that even the one in the pref pane would be using the main strings file too though, come to think of it; since it's defined twice I'm not sure what happens at runtime.

Either way, we definitely need it in the main strings file as well, and if it's currently broken in the prefs I suspect that will fix it.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Simon's adamant that preference panes not read from the main localizable.strings file, so if the Navigation prefPane's menu is reading from there, it's wrong and should be fixed.

I actually filed this because Navigation.prefPane has "Select..." in the menu as part of the nib, but it appears there are in fact multiple problems surrounding this string. :( 

Comment 5

[Stuart Morgan]

I was misunderstanding the bug you were filing.  It's probably not doing what I mentioned above (and what I suggested may not even be possible; I don't know the details of how string lookup location is done for loadable bundles that call into application code).

Anyway, we need the string in the app's Localizable.strings, for app-level code. The nib could be changed too, but that menu is just a placeholder and won't ever show up in the actual UI.

Comment 6

[Nick Kreeger]

Fixing...

Comment 7

[Nick Kreeger]

Fixed trunk and MOZILLA_1_8_BRANCH.