Closed
Bug 352781
Opened 18 years ago
Closed 18 years ago
Need to update Yahoo search tracking codes for ja, ko, and tw to use moz2 by default
Categories
(Firefox :: Search, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: mtschrep, Assigned: mconnor)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
690 bytes,
patch
|
mtschrep
:
review+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
The latest l10n specs indicate that we should be using the same search tracking codes for JKT (note *not* china) that we used for 1.5. I believe we just need to change: http://lxr.mozilla.org/mozilla1.8/source/other-licenses/branding/firefox/pref/firefox-branding.js#14
Reporter | ||
Updated•18 years ago
|
Flags: blocking-firefox2+
Reporter | ||
Updated•18 years ago
|
Severity: critical → normal
Reporter | ||
Comment 1•18 years ago
|
||
Spec here: http://wiki.mozilla.org/Firefox2/L10n_Requirements#Yahoo.21
Comment 2•18 years ago
|
||
This changes fx2-moz-1 -> moz2 for official mozilla shipped builds. schrep, the l10n requirements doc still has the mozilla distributed and mozilla partner distributed builds the wrong way around, at least as far as I read the communication around.
Attachment #238638 -
Flags: review?(mtschrep)
Reporter | ||
Comment 3•18 years ago
|
||
Comment on attachment 238638 [details] [diff] [review] fx2-moz-1 -> moz2 r+=schrep. What's backwards on the spec Axel? We are keeping things the same as 1.5.0.x moz2) until I hear otherwise...
Attachment #238638 -
Flags: review?(mtschrep) → review+
Comment 4•18 years ago
|
||
Comment on attachment 238638 [details] [diff] [review] fx2-moz-1 -> moz2 requesting approval for the branch, this is a branch only patch. Risk is low, though we still need to test that official builds actually pull that pref. Re backwards, that's the wrong term. The ' partner' term is at the wrong build class there. I don't come up with a better explanation.
Attachment #238638 -
Flags: approval1.8.1?
Reporter | ||
Comment 5•18 years ago
|
||
Comment on attachment 238638 [details] [diff] [review] fx2-moz-1 -> moz2 a=schrep
Attachment #238638 -
Flags: approval1.8.1? → approval1.8.1+
Reporter | ||
Comment 6•18 years ago
|
||
Hey axel - I think the "partner" term is correct there.
Comment 7•18 years ago
|
||
Checked in on trunk and branch. Reopen if needed and appropriate later today, I can land minor adjustments over the weekend if that still has a build to make it into. To clarify the comment, I talked to schrep on the phone, what we wanna do is send moz2 for all Mozilla shipped builds. He's going to update the requirements page to say that.
You need to log in
before you can comment on or make changes to this bug.
Description
•