Closed Bug 352785 Opened 18 years ago Closed 18 years ago

When "Always show the tab bar" is checked, Cmd+W does not close window/tab - doesn't comply with Apple HIG

Categories

(Firefox :: Keyboard Navigation, defect)

Product:
Firefox
Component:
Keyboard Navigation
Version:
2.0 Branch
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 348031

People

(Reporter: offsky, Unassigned)

References

Details

(Keywords: regression) 

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b2) Gecko/20060821 Firefox/2.0b2
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b2) Gecko/20060821 Firefox/2.0b2

If "Always show the tab bar" is checked, command-w (the universal close window shortcut) will not work.  

For those who are about to say that I can use command-shift-w to close the window, I would like to point out that command-w is specified in the Apple Design Guidelines to close the window and every decent Mac application ever written functions this way.  I suggest that the behavior return to the way it was with version 1.5x.

Reproducible: Always

Steps to Reproduce:
1. check the "always show the tab bar" option in the Tabs settings
2. Try to close the active window using command-w

Actual Results:  
What really happens is that the tab is closed and replaced with an empty tab.  The empty tab and window cannot be closed with command-w.

Expected Results:  
Command-w should close the front tab.  If there is only 1 tab, the window should close.
Version: unspecified → 2.0 Branch
Summary: command-W should close the window/tab → When "Always show the tab bar" is checked, Cmd+W does not close window/tab
Confirmed.  Needs to be fixed ASAP
This is intentional - see bug 236721 (and the invalid bug 341067). Not resolving this bug however because of the reference to Apple HIG - I'm not sure those have been taken into consideration:  
http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGWindows/chapter_17_section_4.html
http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGMenus/chapter_16_section_4.html
Blocks: 236721
Intentional or not, the new behavior is backwards.  Command-w should close the window as it does in every other application.  Since tabs are essentially a collection of windows, command-w should close the tab, unless there is only 1 tab, in which case it should close the window.  AS per Apple HIG, Option-comamnd-w should close all windows/tabs (not shift-command-w that firefox 2.0b2 currently uses).

For command-w to behave differently depending on the state of the "Always show the tab bar" checkbox, makes no sense.

If the project insists on sticking with the current method, at the very minimum the "Close Tab" menu item should be greyed out (disabled) when there is only 1 empty tab open, since that empty tab cannnot be closed.
(In reply to comment #3)
> Intentional or not, the new behavior is backwards.  Command-w should close the
> window as it does in every other application.  Since tabs are essentially a
> collection of windows, command-w should close the tab, unless there is only 1
> tab, in which case it should close the window. 

Not sure what the "official" take on this is, but it makes sense in Windows also.
Doesn't conform to Apple's Human Interface Guidelines. Works correctly in Camino, Mozilla, Safari, iCab, Opera, FF 1.x, etc. Definatly unexpected and unwanted behavior. Even if this is intentional, it is very VERY annoying.

Not sure if this affects Win/Linux, but most tabbed browsers on those OS's don't do this either.
*** Bug 354303 has been marked as a duplicate of this bug. ***
What do we need to do to get this confirmed and fixed for version 2.0?
There's zero chance this will get fixed for 2.0.

This needs a decision from one of UI guys. Mike (either one), the inconsistency with the HIG doesn't seem to be mentioned on the wiki page, was it taken into consideration when making the change in bug 236721?
Summary: When "Always show the tab bar" is checked, Cmd+W does not close window/tab → When "Always show the tab bar" is checked, Cmd+W does not close window/tab - doesn't comply with Apple HIG
Regardless of whether this is a violation of the Apple HIGs, it is still a MAJOR change from 1.5.x.  This violates every way that every other Mac application functions because, guess what, its not the right thing to do.

This absolutely should be a 2.0 blocker, given that the code to fix it could easily come from the 1.5 branch.

At a VERY minimum, given the this a MAJOR change in behavior, and could conceivably be personal prference any Tony discusses in in bug 236721, it shoudl therefore be a PREFERENCE item (heck, even a hidden item in pref.js that i could change would make me happy).
Status: UNCONFIRMED → NEW
Ever confirmed: true
I think it's important to note that this behaviour should be different on Mac OS X than on Windows or Linux, because in OS X closing the last window doesn't close the application.

I can see why in Windows or Linux you'd want to keep the last window open, even when the last tab has been closed, so as to keep Firefox running (though even that's a dodgy workaround, when it might be better to keep Firefox running in the system tray without any windows).
The problem here is that when the "aways show the tab bar" option is on, if I have two Firefox windows: A and B with multiple tabs opened, closing the last tab of window B does not close window B and return to window A which is the expected behavior, the problem goes beyond the use case of closing the last tab of the last window and how it should behave on different OSs, the use case to support the fix for this regression is a user with multiple windows closing the last tab of a window he does not need anymore and getting stuck in it because Command + W does not work.
Keywords: regression
I was about to file this bug too, so I just wanted to add to the comments in support of reverting to the 1.x behavior. Cmd+W should close the window if there's only one tab. I have no idea why anyone would want it otherwise, and it's extremely annoying that it doesn't work right anymore. Please fix this. It IS wrong.
Please read https://bugzilla.mozilla.org/page.cgi?id=etiquette.html and stop adding useless comments.
Isn't this bug 348031?
Yes, it does look like a dupe.

*** This bug has been marked as a duplicate of 348031 ***
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.