Closed Bug 352805 Opened 18 years ago Closed 9 years ago

nsNSSCertificate::GetDbKey uses the wrong allocator (!= NS_Alloc) to return a value which is then freed by a different wrong allocator (PR_Free - using the inefficient PR_DELETE)

Categories

(Core :: Security: PSM, defect)

x86
SunOS
defect
Not set
critical

Tracking

()

RESOLVED INVALID

People

(Reporter: timeless, Unassigned)

References

()

Details

(Keywords: crash)

Attachments

(1 obsolete file)

credit goes to the solaris compiler for complaining about const/not const. allocator: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/security/nss/lib/util/nssb64e.c&rev=1.3&mark=664,685,687-688,719#664 deallocator: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/security/manager/ssl/src/nsNSSCertificateDB.cpp&rev=1.24&mark=1309,1311#1279 The matching deallocator atm is PORT_Free, but it this is not a legal equivalent for nsMemory.
QA Contact: ui
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #311922 - Flags: review?(rrelyea)
Comment on attachment 311922 [details] [diff] [review] Patch v1 argh, again I missed that the real bug description is contained in the bug's headline only, and missing in the bug description.
Attachment #311922 - Attachment is obsolete: true
Attachment #311922 - Flags: review?(rrelyea)
reassign bug owner. mass-update-kaie-20120918
Assignee: kaie → nobody
This should no longer be an issue with the changes made in Bug 1240173.
Status: NEW → RESOLVED
Closed: 9 years ago
Component: Security: UI → Security: PSM
Depends on: 1240173
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: