352865 - event dialog doesn't warn when trying to move an item to a readonly calendar

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

The event dialog lets you move a calendar to a readonly calendar, without any warning. Ofcourse, moving to readonly should not be possible

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: check on change of menulist

patch makes changing the item in the menulist also call updateAccept, which was already setup to warn on trying to move to a readonly calendar.

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 238659 [details] [diff] [review]
check on change of menulist

Nice catch.
r1=lilmatt

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 238659 [details] [diff] [review]
check on change of menulist

Seems like the proper UI fix for this is that for events that are in writable calendars, don't show any readonly calendars in the menu.  And for events that are in a readonly calendar, 
we should somehow be disabling that UI entirely, perhaps by making it a label instead of a menu.

That said, this patch improves the status quo in a significant way, so r=dmose on it assuming that spinoff bug is filed on doing the right thing.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Since it prevents the worst dataloss case in bug 307556, making this block instead of that one.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in

Comment 6

[Stefan Sitter [:ssitter]]

If you would have done review on bug 352247 this would have been fixed already ;-)

Comment 7

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060917 Calendar/0.3a2+

Comment 8

[Damian Szczepanik]

Litmus testcase 2694 created