352911 - leak when closing window while it contains a google maps page (missing ClearScope on outer window)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm seeing major leaks, I think because JS_ClearScope and perhaps some other cleanup code is missing from one of the window teardown paths.

Steps to reproduce:
 1. start firefox
 2. load http://dbaron.org/maps/geotagged-photos
 3. close the window

Actual results: the document and both the inner and outer windows leak

Note that if you navigate to a different page between (2) and (3), there's no leak.

The leak seems to be due to a cycle that should have been broken by a JS_ClearScope:

0a4de740 object 0xa502a68 HTMLDocument via locked object(Window @ 0x0a4de230).XPCWrappedNative::mNativeWrapper(XPCNativeWrapper @ 0x0a4de798).__proto__(XPCNativeWrapper @ 0x0a4de328).__parent__(Window @ 0x0a23fa18).GLoadApi(Function @ 0x0a720d58).__parent__(Call @ 0x0a720ae0).__proto__(Call @ 0x0a720ad8).arguments(Object @ 0x0a82e660).0(Object @ 0x0aab1840).photos(Array @ 0x0aab1848).0(Object @ 0x0a507338).marker(Object @ 0x0a8b1618).a(Object @ 0x0a507780).b(HTMLDivElement @ 0x0a507768).nsDOMClassInfo::sPreservedWrapperTable(HTMLImageElement @ 0x0a7bbec8).__parent__(HTMLDocument @ 0x0a4de740).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is a regression *since* the 1.8 branch.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This fixes the leak, and I think it does what was intended here.  Instead of repeating the clearing of the inner window's global that was just done in FreeInnerObjects, this clears the outer window's global.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 238723 [details] [diff] [review]
patch

sr=jst

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 238723 [details] [diff] [review]
patch

Oh, but please do pull this code up to the previous line now that it fits.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

All 3 lines even fit on one now!

Comment 6

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 238723 [details] [diff] [review]
patch

yeah, it looks like I did get that confused.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.