Closed Bug 35293 Opened 24 years ago Closed 23 years ago

PERF: nsHTMLEditRules::WillInsertText() performance

Categories

(Core :: DOM: Editor, defect, P1)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Future

People

(Reporter: mozeditor, Assigned: mozeditor)

References

Details

(Keywords: perf, Whiteboard: [nsbeta3-][rtm-][p:1]) 

WillInsertText() takes too much time before it starts hucking in the text.  It 
may be from copying the input string - I need to investigate and fix.
Blocks: 28783
i accept Bugzilla as my lord and savior.
Status: NEW → ASSIGNED
m17
Target Milestone: --- → M17
Adding perf keyword
Keywords: perf
moving to m19
Target Milestone: M17 → M19
please do not nominate for nsbeta3 -- this will be addressed after crashes, 
regressions, correctness and polish bugs have been resolved, all Composer perf 
bugs have been set to m19/m20
performance improvements
Keywords: nsbeta3
Priority: P3 → P2
Whiteboard: [nsbeat3+][p:2]
oops, marked the wrong bug, this should have been futured
Whiteboard: [nsbeat3+][p:2] → [nsbeta3-][p:2]
Target Milestone: M19 → Future
having a bad day -- this was supposed to be nsbeat3+ and p2 based on the review
by Bijal and beppe
Whiteboard: [nsbeta3-][p:2] → [nsbeta3+][p:2]
Target Milestone: Future → M19
Blocks: 53252
No longer blocks: 28783
major performance impact on paste
Priority: P2 → P1
Whiteboard: [nsbeta3+][p:2] → [nsbeta3-][rtm+][p:1]
this bug lacks the necessary data:
  How slow is it?  I need numbers here!
  How fast would it be after the proposed fix?  (Again, numbers!)
I doubt pdt will approve without the above information...

PDT will also need to know:
  How often will users see this and in what situations?
  This bug impacts: text inputs, textareas, urlbar, mail compose, Composer, etc.

Joe, please include the required information per the rtm checkin rules
Whiteboard: [nsbeta3-][rtm+][p:1] → [nsbeta3-][rtm+ NEED INFO][p:1]
PDT marking [rtm-] since performance impact is not quantified. Please renominate
if/when we know how bad the problem is.
Whiteboard: [nsbeta3-][rtm+ NEED INFO][p:1] → [nsbeta3-][rtm-][p:1]
agree with Kathy completely, pushing out to future
Target Milestone: M19 → Future
Keywords: mailtrack
I'd like to nominate this for nsbeta1.  I think this is one of the bugs that
affects message reply performance due to inserting text (if it's not one of the
bugs then ignore the nsbeta1 nomination and let me know).  reply performance is
one of our key areas and it looks like Jean-Francois data shows that we'd get a
big win if we could speed up inserting text.
Keywords: nsbeta1
Blocks: 28783
Hmm, text copying was fixed a long time ago with SubsumeStr.  closing out.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
v=jfrancis
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.