353025 - Search engine in Search Bar is randomly changed every time search updates are checked

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[IU]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20060916 BonEcho/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20060916 BonEcho/2.0

Whenever Bon Echo runs a search engine update check, it "randomly" changes the search engine appearing in the search bar.  I was able to confirm this after I suddenly noticed my search engines changing before my eyes, accompanied with a lot of disk activity.  When I went to about:config and checked the time for app.update.lastUpdateTime.searc-engine-update-timer, it matched the time of occurrence.  Others have also reported being affected by this issue (see: http://forums.mozillazine.org/viewtopic.php?p=2485017#2485017)


Reproducible: Always

Steps to Reproduce:
1. Configure Bon Echo to "Automatically check for updates to:" Search Engines
2. Install a few additional search engines, for good measure. :-)
3. Modify browser.search.updateinterval so the check occurs sooner (or more frequently), say 1 hour
4. Wait.  It might take a few hits to present the issue.


Actual Results:  
Too impatient so didn't try.  I have seen this bug many times, and, as indicated above, others experiencing the issue have also mentioned it on the Mozillazine "Firefox Builds" thread.


Expected Results:  
Checking for search engine updates should not modify the user selected search engine.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This is an indirect regression from bug 348141, where the default for _useNow was changed to true. This means that update-only engines now have _useNow set, which causes nsIBrowserSearchService::observe to select them when they load. We need to explicitly ensure that this doesn't happen for engine-only loads, by setting _useNow to false.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #1)
> need to explicitly ensure that this doesn't happen for engine-only loads, by
> setting _useNow to false.

I meant "update-only loads", of course.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 238909 [details] [diff] [review]
patch

very straightforward, r+a=me, please get this in ASAP

Comment 4

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.1.2.70

Comment 5

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.86

Comment 6

[:Gavin Sharp [email: [e-mail]]]

IU: I would greatly appreciate it if you could verify (or ask others to verify on the forum) that builds including the patch I just checked in no longer show the bug.

Comment 7

[IU]

Gavin, thanks for fixing this so quickly.  I'll check the build out over the next couple days then post a confirmation.  And as requested, I'll also post, tomorrow morning, asking others to verify.

Comment 8

[IU]

Haven't seen this occur again, nor has anyone else reported seeing it.  Therefore, verifying fixed.  Thanks.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Thanks for verifying (and filing!), IU.

Comment 10

[Phil Ringnalda (:philor)]

*** Bug 353143 has been marked as a duplicate of this bug. ***