Closed Bug 353044 Opened 13 years ago Closed 13 years ago

calMonthPrinter calls toXMLString() twice (unnecessarily performance lost)

Categories

(Calendar :: Printing, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ssitter, Assigned: ssitter)

References

()

Details

(Keywords: perf)

Attachments

(1 file)

In calMonthPrinter.prototype.formatToHtml there is a dump statement that writes the created html to console. As the result html.toXMLString() is called twice resulting in unnecessarily performance lost.

Removing the dump gives us a quick performance win because formatToHtml() is called every time you change a setting in Print dialog. 

http://lxr.mozilla.org/mozilla/source/calendar/import-export/calMonthGridPrinter.js#165
Attached patch remove dumpSplinter Review
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #238892 - Flags: second-review?(jminta)
Attachment #238892 - Flags: first-review?(mattwillis)
Comment on attachment 238892 [details] [diff] [review]
remove dump

r1=lilmatt
Attachment #238892 - Flags: first-review?(mattwillis) → first-review+
Comment on attachment 238892 [details] [diff] [review]
remove dump

r2=jminta
Attachment #238892 - Flags: second-review?(jminta) → second-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.