Closed
Bug 353044
Opened 18 years ago
Closed 18 years ago
calMonthPrinter calls toXMLString() twice (unnecessarily performance lost)
Categories
(Calendar :: Printing, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ssitter, Assigned: ssitter)
References
()
Details
(Keywords: perf)
Attachments
(1 file)
|
1.30 KB,
patch
|
mattwillis
:
first-review+
jminta
:
second-review+
|
Details | Diff | Splinter Review |
In calMonthPrinter.prototype.formatToHtml there is a dump statement that writes the created html to console. As the result html.toXMLString() is called twice resulting in unnecessarily performance lost.
Removing the dump gives us a quick performance win because formatToHtml() is called every time you change a setting in Print dialog.
http://lxr.mozilla.org/mozilla/source/calendar/import-export/calMonthGridPrinter.js#165
|
Assignee | |
Comment 1•18 years ago
|
||
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #238892 -
Flags: second-review?(jminta)
Attachment #238892 -
Flags: first-review?(mattwillis)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 238892 [details] [diff] [review]
remove dump
r1=lilmatt
Attachment #238892 -
Flags: first-review?(mattwillis) → first-review+
|
||
Comment 3•18 years ago
|
||
Comment on attachment 238892 [details] [diff] [review]
remove dump
r2=jminta
Attachment #238892 -
Flags: second-review?(jminta) → second-review+
|
|
||
Comment 4•18 years ago
|
||
Patch checked in on MOZILLA_1_8_BRANCH and trunk.
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•