353368 - Tab reflow / bookmarks toolbar could be a little smoother when resizing

Status: NEW

(Firefox :: Tabbed Browser, defect)

Description

[Marcia Knous [:marcia]]

Seen testing Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20060918 Firefox/2.0.

STR:

1. Open a bunch of tabs and begin vigorously resizing the window.
2. Receive the attached screenshot

I showed this to seth, I think the behavior could be improved somewhat for the end user.  Could we reflow on the fly so that we don't see gaps as show in the screenshot?

Comment 1

[Marcia Knous [:marcia]]

Attachment: Screenshot of a window with lots of tabs that I am resizing

You can't see all the tabs I have open, but there are more than 60-70 tabs open at this point when I am trying to resize the window.

Comment 2

[(not reading, please use [e-mail] instead)]

thanks for the screen shot and the bug, marcia.

in the screen shot, I see that the bookmarks overflow chevron has also not updated on resize.

perhaps we need an additional handler (for the tab case, in scrollbox.xml) for the "resize" DOMEvent, upon which we would call ensureElementIsVisible(), similar to what we do in the "underflow" handler?

http://lxr.mozilla.org/mozilla1.8/source/toolkit/content/widgets/scrollbox.xml#166

Asaf, what do you think?

Comment 3

[Asaf Romano (gone)]

Er? AFAIR we do have a resize handler in tabbrowser.xml, and the issue here is "fixed" once you stop resizing the window, right?

In that case, the reason you see this is because the resize event isn't "live", i.e. its only dispatched once you stop resizing the window. I don't know of a any JS way to fix this...

Comment 4

[(not reading, please use [e-mail] instead)]

> Er? AFAIR we do have a resize handler in tabbrowser.xml

yes, we do.  (See http://lxr.mozilla.org/mozilla1.8/source/toolkit/content/widgets/tabbrowser.xml#2685)

> and the issue here is "fixed" once you stop resizing the window, right?

yes, the issues is "fixed" once you stop.

> In that case, the reason you see this is because the resize event isn't"live",
> i.e. its only dispatched once you stop resizing the window. I don't know of a
> any JS way to fix this...

I don't know how to do this, either. 

note, the personal toolbar has the same issue (as evident in marcia's screen shot), so I've updated the summary.