Camino ships 2 copies of the table images

RESOLVED FIXED

Status

RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: alqahira, Assigned: alqahira)

Tracking

({fixed1.8.1.1})

Details

Attachments

(2 attachments)

We ship 2 copies of all of the table images:

1) Camino.app/Contents/MacOS/res
2) Camino.app/Contents/Resources

Is there some reason we're doing this?  The images are different, and I'm not really sure where they're used ever, so I can't tell which ones are used....

Comment 1

13 years ago
The explicit include we do looks like it came from when we added Midas, so that's probably where they are used.

Comment 2

13 years ago
Oh, we explicitly do both copies; once as part of the general resources copy, and one specific build phase copy. I would hazard a guess that the Resources copy was an accident--IIRC, Xcode helpfully adds things there that you put in the main resources folder.

We should just find a Midas test that uses them, rip out the Resources copy of all that stuff, and make sure it still works.

Comment 3

13 years ago
(In reply to comment #2)
> Oh, we explicitly do both copies; once as part of the general resources copy,
> and one specific build phase copy. I would hazard a guess that the Resources
> copy was an accident--IIRC, Xcode helpfully adds things there that you put in
> the main resources folder.

This is almost certainly the case. Gecko doesn't know anything about the Resources folder.
I'll look at kicking the project for this, then.  I remember this "feature" of Xcode being helpful from chardet. :P
Assignee: nobody → alqahira

Comment 5

13 years ago
http://www.mozilla.org/editor/midasdemo/ has a demo, and you can see these images when you insert a table. I ripped out all the Resources copies and it still worked fine, which supports the mistake theory.

So all we need here is a project patch which removes the following files from the "Copy Bundle Resources" phase of the Camino and CaminoStatic targets:
grabber.gif
table-*.gif
EditorOverride.css
Posted patch Trunk patchSplinter Review
In addition to removing the Midas crap identified by Stuart from the Bundle Resources Copy Phase (BRCP) in both targets, this

1) removes layout_xul_tree.xpt from the BRCP in both targets
2) removes libpermissions.dylib, libucvmath.dylib, and libchardet.dylib from the BRCP in the non-static target
3) removes the Wallet schema tables from the BRCP in the static target

All of these files are duplicated in various Gecko copy phases, but I ran cursory checks of XUL trees, cookie permissions, MathML, chardet, and form fill in my debug build anyway, and all was well ;)
Attachment #245724 - Flags: review?
Posted patch Branch patchSplinter Review
In addition to removing the Midas crap identified by Stuart from the Bundle Resources Copy Phase (BRCP) in both targets, this

1) removes layout_xul_tree.xpt from the BRCP in both targets
2) removes libucvmath.dylib from the BRCP in the non-static target

All of these files are duplicated in various Gecko copy phases, but I ran cursory checks of XUL trees and MathML in my debug build anyway, and all was well ;)
Attachment #245727 - Flags: superreview?(mark)
Comment on attachment 245724 [details] [diff] [review]
Trunk patch

Mento, if you can't get to these quickly, can you holler, or poke another qualified Camino sr?  ;) They'll bitrot pretty quickly if we have other project changes (and some are expected, iirc).
Attachment #245724 - Flags: review? → superreview?(mark)
Comment on attachment 245724 [details] [diff] [review]
Trunk patch

These have sr=smorgan per irc.
Attachment #245724 - Flags: superreview?(mark) → superreview+
Comment on attachment 245727 [details] [diff] [review]
Branch patch

sr=smorgan per irc
Attachment #245727 - Flags: superreview?(mark) → superreview+
Whiteboard: [needs checkin]
Checked in on 1.8branch and trunk.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
You need to log in before you can comment on or make changes to this bug.