353411 - Approval: Fixes to Turkish Firefox 2

Status: VERIFIED FIXED

(Mozilla Localizations :: tr / Turkish, defect)

Description

[Ahmet Serkan Tıratacı]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; tr; rv:1.8.1b2) Gecko/20060913 BonEcho/2.0b2
Build Identifier: 

We'd like to fix a few strings as suggested by third party review at http://people.mozilla.com/~timr/FF2.0/L10n/tr/

Patches will follow as soon as we make them.

Reproducible: Always

Comment 1

[Ahmet Serkan Tıratacı]

Attachment: patch for browser.dtd

This's the patch for already-checked-in browser.dtd.

Patch is not easy to read, probably due to encoding or so.

Diff by another application is here:

browser.1.12.2.29.dtd
browser.1.12.2.30.dtd

-<!ENTITY mainWindow.titlemodifiermenuseparator "  -  ">
+<!ENTITY mainWindow.titlemodifiermenuseparator " - ">

-<!ENTITY manBookmarksCmd.label "Yer imlerini yönet...">
+<!ENTITY manBookmarksCmd.label "Yer imlerini düzenle...">

-<!ENTITY openFileCmd.label "Aç...">
+<!ENTITY openFileCmd.label "Dosya aç...">

-<!ENTITY sendPageCmd.label "Sayfayı gönder...">
+<!ENTITY sendPageCmd.label "Bağlantıyı gönder...">

Comment 2

[Ahmet Serkan Tıratacı]

Attachment: patch for charsetTitles.properties.patch

This's the patch for already-checked-in charsetTitles.properties.

Comment 3

[Ahmet Serkan Tıratacı]

Attachment: patch for pageInfo.dtd

This's the patch for already-checked-in pageInfo.dtd.

Patch is not easy to read, probably due to encoding or so.

Diff by another application is here:

pageInfo.1.3.2.3.dtd
pageInfo.1.3.2.4.dtd

-<!ENTITY generalModified "Değiştirne tarihi:">
+<!ENTITY generalModified "Değişme tarihi:">

Comment 4

[Ahmet Serkan Tıratacı]

Attachment: patch for pippki.properties

This's the patch for already-checked-in pippki.properties.

Patch has some extra minus and plus sings probably due to encoding or so.

The only changes by another application is here:

pippki.1.6.2.5.properties
pippki.1.6.2.6.properties

-pageInfo_SiteNotVerified=Web sayfa kimliği kontrol edilmedi
+pageInfo_SiteNotVerified=Web sayfası kimliği kontrol edilmedi

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 239374 [details] [diff] [review]
patch for browser.dtd

I wouldn't have approved this patch, but this landed, and thus it's too late.

This is a typical result from mailing files instead of patches, you likely reverted the line endings. Bah.

For future reference, before committing, do a cvs diff -u and look if the changeset is actually what you intend to change.

And don't submit patches for each file extra, that's just noise.

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 239376 [details] [diff] [review]
patch for charsetTitles.properties.patch

This would have been approved, if you look at the patch after setting your character set to utf-8, it won't look funny anymore.
For future reference, no idea how much context you used, but the default 3 is enough in general.

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 239377 [details] [diff] [review]
patch for pageInfo.dtd

This patch has confused line endings and wouldn't have been approved as is.

Too late to fix that now, though.

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 239378 [details] [diff] [review]
patch for pippki.properties

Not sure what this changes, I see only reverting utf-8 to unicode escapes here.

I wouldn't have approved this patch, too.

Comment 9

[Ahmet Serkan Tıratacı]

Attachment: patch for preferences.dtd

Not directly related to the review, but this fixes the window size problem under Windows Classic theme.

Comment 10

[Ahmet Serkan Tıratacı]

Attachment: patch for charsetOverlay.dtd

This is related to review. Unikodu -> Unicode

Comment 11

[Ahmet Serkan Tıratacı]

Sorry again for commiting changes before getting approval. It was a communication problem between me and Erkan, caused by me as I said before.

Me and Erkan use different tools and different operating systems. That's why we sometimes face such encoding problems. Sorry for that too.

Comment 12

[Axel Hecht [:Pike]]

It's not an encoding problem, but a line ending problem. dos2unix can help converting those in both directions, and is available for unix and as part of cygwin for windows. If your cvs client is setup to use unix line endings, just doing a 
dos2unix file
fixes the issue. Confirm by doing a cvs diff.

The patches to charsetOverlay.dtd and preferences.dtd are new, right? I'll go through those once we have another engineering window.

Comment 13

[Ahmet Serkan Tıratacı]

(In reply to comment #12)
> It's not an encoding problem, but a line ending problem. dos2unix can help
> converting those in both directions, and is available for unix and as part of
> cygwin for windows. If your cvs client is setup to use unix line endings, just
> doing a 
> dos2unix file
> fixes the issue. Confirm by doing a cvs diff.

We'll take care of this. Noted.

> 
> The patches to charsetOverlay.dtd and preferences.dtd are new, right? I'll go
> through those once we have another engineering window.
> 

Yes. One (window size issue) is reported today by a friend, and the other is related to the third party review but not mentioned in the report.

I could file another last-minute-fix bug, but I preferred to deal with all remaining issues in this bug. We won't have any more fixes other than these.

Comment 14

[Mike Schroepfer]

Axel are these good to go?

Comment 15

[Axel Hecht [:Pike]]

Comment on attachment 239380 [details] [diff] [review]
patch for preferences.dtd

This one is. Please check my post in .l10n, too.

Comment 16

[Ahmet Serkan Tıratacı]

We have just checked in the last two patches (patch for preferences.dtd and patch for charsetOverlay.dtd), but haven't verified yet.

While Erkan was commiting one of these two pathes, he
accidently typed another bug number (239380) in description of the patch. Of course, he meant to write 353411.
https://bugzilla.mozilla.org/show_bug.cgi?id=353411

You can see this latest two commiting at
http://bonsai-l10n.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=l10n%2Ftr&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=week&mindate=&maxdate=&cvsroot=%2Fl10n

This's an important window size fix for Windows users. I'm writing here to let you know that that this patch is for bug 353411 (this one), not for accidently-mentioned bug 239380.

I'll mark this bug VERIFIED FIXED as soon as we verify fixing.

Comment 17

[Ahmet Serkan Tıratacı]

Fixed and verified!