Last Comment Bug 353413 - Klocwork 76541 free uninitialized pointer in CERT_FindCertURLExtension
: Klocwork 76541 free uninitialized pointer in CERT_FindCertURLExtension
Status: RESOLVED FIXED
: klocwork
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.11
: All All
: P2 normal (vote)
: 3.12
Assigned To: Alexei Volkov
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-09-19 16:21 PDT by Nelson Bolyard (seldom reads bugmail)
Modified: 2006-10-04 11:27 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
init baseitem and urlitem before allocating arena (1.31 KB, patch)
2006-09-27 17:41 PDT, Alexei Volkov
nelson: review+
Details | Diff | Review

Description Nelson Bolyard (seldom reads bugmail) 2006-09-19 16:21:59 PDT
In file nss/lib/certdb/certv3.c function CERT_FindCertURLExtension,
at label "done", baseitem.data and urlitem.data are freed if non-NULL.
Neither is initialized if PORT_NewArena returns NULL at line 118.

Klocwork items 76541 and 76542
Comment 1 Alexei Volkov 2006-09-27 17:41:05 PDT
Created attachment 240389 [details] [diff] [review]
init baseitem and urlitem before allocating arena
Comment 2 Nelson Bolyard (seldom reads bugmail) 2006-09-27 20:54:52 PDT
Comment on attachment 240389 [details] [diff] [review]
init baseitem and urlitem before allocating arena

r=nelson for trunk
Comment 3 Alexei Volkov 2006-09-29 13:20:38 PDT
/cvsroot/mozilla/security/nss/lib/certdb/certv3.c,v  <--  certv3.c
new revision: 1.9; previous revision: 1.8

Note You need to log in before you can comment on or make changes to this bug.