Last Comment Bug 353423 - Klocwork bugs in nss/lib/pk11wrap/dev3hack.c
: Klocwork bugs in nss/lib/pk11wrap/dev3hack.c
Status: RESOLVED FIXED
: klocwork
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: trunk
: All All
: P2 normal (vote)
: 3.12
Assigned To: Alexei Volkov
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-09-19 17:08 PDT by Nelson Bolyard (seldom reads bugmail)
Modified: 2006-10-09 15:14 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
check returned pointers value for NULL (1.60 KB, patch)
2006-10-04 13:20 PDT, Alexei Volkov
nelson: review+
Details | Diff | Splinter Review

Description Nelson Bolyard (seldom reads bugmail) 2006-09-19 17:08:31 PDT
Klocwork ID 76908
File     nss/lib/pk11wrap/dev3hack.c 
Function nssToken_CreateFromPK11SlotInfo

Pointer 'rvToken->slot' returned from call to function 'nssSlot_CreateFromPK11SlotInfo' at line 199 may be NULL and will be 
dereferenced at line 200 and line 201.

Klocwork ID 91119
file     nss/lib/pk11wrap/dev3hack.c 
Function nssSession_ImportNSS3Session

Pointer 'rvSession' returned from call to function 'nss_ZAlloc' at 
line 70 may be NULL and will be dereferenced at line 71.
Comment 1 Alexei Volkov 2006-10-04 13:20:17 PDT
Created attachment 241208 [details] [diff] [review]
check returned pointers value for NULL
Comment 2 Nelson Bolyard (seldom reads bugmail) 2006-10-04 13:40:03 PDT
Comment on attachment 241208 [details] [diff] [review]
check returned pointers value for NULL 

r=nelson
Comment 3 Alexei Volkov 2006-10-09 15:14:17 PDT
/cvsroot/mozilla/security/nss/lib/pk11wrap/dev3hack.c,v  <--  dev3hack.c
new revision: 1.22; previous revision: 1.21

Note You need to log in before you can comment on or make changes to this bug.