353514 - Error when viewing the "Liste des menus" help page

Status: RESOLVED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[Frédéric Buclin]

Type F1 to load help. Select the "Liste des menus" item in the left panel. You get an error instead of the help page:

Erreur d'analyse XML : entité non définie
Emplacement : jar:file:///usr/local/firefox/chrome/fr.jar!/locale/browser/help/menu_reference.xhtml
Numéro de ligne 466, Colonne 24 :
  <h3 id="web_forgery">&reportPhishSiteMenu.title;</h3>
-----------------------^

Comment 1

[Frédéric Buclin]

marcia suggested to put it in the radar for Fx2.

Comment 2

[Marcia Knous [:marcia]]

Just to be clear, the whole subsection gives XML errors, not just one sub heading - so everything under Liste des Menus is hosed with an XML error.  The other sections of help appear to be unaffected.

Comment 3

[Mike Schroepfer]

If we did an RC2 we'd definitely want this...

Comment 4

[Marcia Knous [:marcia]]

Changing HW and Platform to all, this is present on Windows XP and Mac as well.

Comment 5

[Cédric Corazza]

Attachment: Fixing the Help parsing error

Hi. Well, this is due to the last check-in on this file:
http://bonsai-l10n.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=l10n/fr/browser/chrome/help&command=DIFF_FRAMESET&file=menu_reference.xhtml&rev1=1.10.2.23&rev2=1.10.2.24&root=/l10n
I certainly forgot to validate this file opening it in Firefox after having spent the last weekend to localize prefs.xhtml file.

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 239386 [details] [diff] [review]
Fixing the Help parsing error

Let's only deal with the approval1.8.1 flag here.

Comment 7

[Cédric Corazza]

As this bug is "blocking‑firefox2 +", should I add that it also blocks bug 350038 ?

Comment 8

[Axel Hecht [:Pike]]

Sounds like a good idea.

Comment 9

[Mike Schroepfer]

Comment on attachment 239386 [details] [diff] [review]
Fixing the Help parsing error

Approved for RC2 (fr help).

Comment 10

[Cédric Corazza]

Verified on Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1) Gecko/20060923 BonEcho/2.0 tinderbox build 9141 KB 23.09.2006 14:12:00

Comment 11

[Frédéric Buclin]

Yup, thanks for the fix.