Closed
Bug 353601
Opened 19 years ago
Closed 19 years ago
Remove style from nsIDOMXULElement
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: WeirdAl, Assigned: WeirdAl)
References
Details
Attachments
(2 files)
|
3.50 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
|
3.67 KB,
patch
|
Details | Diff | Splinter Review |
<bz> why was this on nsIDOMXULElement to start with?
And can we remove it from there??
I don't really like having two separate interfaces exposing identical methods
Change QIs to nsIDOMElementCSSInlineStyle as needed
|
Assignee | |
Comment 1•19 years ago
|
||
tested by compiling SeaMonkey.
Attachment #239470 -
Flags: superreview?(bugmail)
Attachment #239470 -
Flags: review?(bugmail)
Comment on attachment 239470 [details] [diff] [review]
patch, v1
I'd prefer having GetStyle public and remove the |friend|
r/sr=sicking with that.
Attachment #239470 -
Flags: superreview?(bugmail)
Attachment #239470 -
Flags: superreview+
Attachment #239470 -
Flags: review?(bugmail)
Attachment #239470 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Interestingly, that was my first stab at it, and then I thought, "Wouldn't this make more sense as a private member?" But that's fine with me!
|
||
Comment 4•19 years ago
|
||
checked in to the trunk.
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•