Closed
Bug 353689
Opened 18 years ago
Closed 18 years ago
improve nsLocalUndoFolderListener::OnItemEvent
Categories
(MailNews Core :: Backend, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 obsolete file)
neil didn't like this function when he saw it in bug 352647
Attachment #239543 -
Flags: superreview?(neil)
Attachment #239543 -
Flags: review?(neil)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 239543 [details] [diff] [review] this should work timeless, I don't think it's unclear to put the if on two lines instead of 3.
Attachment #239543 -
Flags: superreview?(neil)
Attachment #239543 -
Flags: superreview+
Attachment #239543 -
Flags: review?(neil)
Attachment #239543 -
Flags: review?(bienvenu)
|
||
Comment 3•18 years ago
|
||
Comment on attachment 239543 [details] [diff] [review] this should work r=bienvenu but to amplify Neil's comment - it's easier to read if the first two if clauses are on one line.
Attachment #239543 -
Flags: review?(bienvenu) → review+
Comment on attachment 239543 [details] [diff] [review] this should work mozilla/mailnews/local/src/nsLocalUndoTxn.cpp 1.47 mozilla/mailnews/local/src/nsLocalUndoTxn.cpp 1.48
Attachment #239543 -
Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•