353698 - error when editing deleted event

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Damian Szczepanik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060921 Calendar/0.3a2+

Delete option should be disabled when event is deleted (specially then it was last event in calendar)

Reproducible: Always

Steps to Reproduce:
1. create new profile
2. create event
3. from context menu select delete event
4. from context menu select edit event
5. press enter

Actual Results:  
error console:

Error: Severe error in internal transaction code!
ID does not already exist for modifyItem
Please report this to the developers.

Source File: chrome://calendar/content/calendar-item-editing.js
Line: 297

Expected Results:  
delete item should be disabled

Comment 1

[Joey Minta]

Attachment: fire event when appropriate

We should fire an itemselect event if an item being deleted was previously selected.  This allows the listener to properly update the menuitems.

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 250806 [details] [diff] [review]
fire event when appropriate

r=lilmatt with a one-line comment in each file above your change explaining why you're doing what you're doing there

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 250806 [details] [diff] [review]
fire event when appropriate

r2=mvl, but indeed add a comment. It took me some time to figure out what the code does, and i even had the hint that it should fix this bug.

Comment 4

[Joey Minta]

patch checked in, with the comment.

Comment 5

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070111 Calendar/0.4a1