353721 - Media Preview window in Page Info should change its background depending on the image color

Status: NEW

(Firefox :: Page Info Window, enhancement)

Description

[Masahiro YAMADA]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; ja; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; ja; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7

Current background color of media preview ("Page Info" - "Media Preview") is white.

When showing image contains only white and transparent
(i.e,http://www.mozilla.gr.jp/images/toppng/logo.png) , it is invisible.

Reproducible: Always

Steps to Reproduce:
1.Show HTML contains white and transparent only image 
2.Show Media preview in Page Info
3.

Actual Results:  
Image is invisible. Because background has same color.

Expected Results:  
If background color of Media Preview is changeable , I can see the image.

It would be nice to change background color of Media Preview from white to system color of window background.

Comment 1

[Adam Guthrie]

Florian, is this something you might be able to tackle (or is SoC over)?

Comment 2

[Florian Quèze [:florian]]

(In reply to comment #1)
> Florian, is this something you might be able to tackle (or is SoC over)?
> 

SoC is over, but it doesn't mean that I'm going to stop hacking page info ;-)

See bug 137733 which is the same for Seamonkey. There's a patch in it.

Comment 3

[Masahiro YAMADA]

Here is part of my userChrome.css.
It changes Media Preview Background Depending on Windows System Color.

vbox.inset.iframe {
	background-color: window !important;
}

But it changes all background-color of "vbox.inset.iframe". 
I could not find unique id of Media Preview Background.

Comment 4

[Tanner M. Young [:tmyoung]]

#thepreviewimage {
  background-color: black;
}
or 
#theimagecontainer {
  background-color: black;
}

Both of the above fix the problem for this image very nicely (I am partial to the first), but neither case fix cases for images that are black text or lines on transparency.  That issue has been the main debate in Bug 137733, because one can either have one or the other, not both.  A crazy solution could be creating a drag bar, or something like that, in the view area that you can select grayscale from white to black and it changes the background color of the image, which wouldn't be too hard, but it likely wouldn't look good or elegant.

Comment 5

[Tanner M. Young [:tmyoung]]

Since there is a new background visible when users run the "View Image" command (the black and gray background).  Page Info probably should use it for consistency and it appears to be designed to solve this same problem in an empty browser window.  Since this background is already packaged with Firefox for View Image, it should be very simple to load it in Page Info, and would likely be a good first bug/beginner bug.

Comment 7

[Djfe]

wow, this is ancient haha

pretty cool, that you are the triage owner now :)
would be cool if this actually would be tagged as good first bug

Comment 8

[Florian Quèze [:florian]]

(In reply to Djfe from comment #7)

would be cool if this actually would be tagged as good first bug

Would you like to fix it yourself?

Comment 9

[Djfe]

ups, started replying but then got caught up in something else and never send the reply.

fixing something in Firefox, mmh I've thought about getting involved every now and then.
Biggest problem for me is likely the knowledge gap.
and the time needed to setup a build environment, to get familiar with the code etc.

I'll think about it.
Right now I'm occupied with other stuff
and I want to keep helping out in the German translation community.

maybe I'll start with coding at another project first (like common voice. because I already got involved there)