Closed
Bug 353732
Opened 18 years ago
Closed 18 years ago
Have a version of evalInSandbox that takes an nsIPrincipal, not a URI string
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: mrbkap)
References
Details
Attachments
(1 file)
|
1.23 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Once bug 351370 lands this should be pretty straightforward to do, and it could be useful on trunk where chrome script can get at principals.
|
Reporter | |
Comment 1•18 years ago
|
||
Note that one can already pass in a window. Not sure why we require a window and not a general nsIScriptObjectPrincipal (say a document)...
|
||
Updated•18 years ago
|
Assignee: dbradley → nobody
|
Assignee | |
Comment 2•18 years ago
|
||
I think this is all that's needed to fix this bug. Most of it was fixed by bug 351370.
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #268437 -
Flags: superreview?(jst)
Attachment #268437 -
Flags: review?(jst)
|
||
Updated•18 years ago
|
Attachment #268437 -
Flags: superreview?(jst)
Attachment #268437 -
Flags: superreview+
Attachment #268437 -
Flags: review?(jst)
Attachment #268437 -
Flags: review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•18 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•